Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 8965013: Fix the issue that omnibox is editable when menu is opened in aura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove some unnecessary code. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_controller.cc
diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc
index f0c1cc1f04b8528ced9ef4f6b32ba6b99b846c81..8c746140e1cd4e6507b0359738614eef52007c30 100644
--- a/ui/views/controls/menu/menu_controller.cc
+++ b/ui/views/controls/menu/menu_controller.cc
@@ -889,13 +889,13 @@ base::MessagePumpDispatcher::DispatchStatus
}
switch (ui::EventTypeFromNative(xev)) {
case ui::ET_KEY_PRESSED:
- OnKeyDown(ui::KeyboardCodeFromNative(xev));
- // OnKeyDown may have set exit_type_.
- if (exit_type_ != EXIT_NONE)
+ if (!OnKeyDown(ui::KeyboardCodeFromNative(xev)))
return base::MessagePumpDispatcher::EVENT_QUIT;
// TODO(oshima): support SelectChar
- break;
+ // See http://crbug.com/107869
oshima 2011/12/16 18:21:33 nit: period at the end of both lines.
jennyz 2011/12/16 18:26:39 Done.
+
+ return base::MessagePumpDispatcher::EVENT_PROCESSED;
case ui::ET_KEY_RELEASED:
return base::MessagePumpDispatcher::EVENT_PROCESSED;
default:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698