Fix the issue that omnibox is editable when menu is opened in aura.

Fix the issue that omnibox is editable when menu is opened in aura.


BUG=106950
TEST=omnibox is not editable when wrench menu is opened.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114853

[sky, 2011-12-16 00:30:11]

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:892:
OnKeyDown(ui::KeyboardCodeFromNative(xev));
You should actually check the return value of OnKeyDown.

[oshima, 2011-12-16 00:37:12]

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:892:
OnKeyDown(ui::KeyboardCodeFromNative(xev));
On 2011/12/16 00:30:11, sky wrote:
> You should actually check the return value of OnKeyDown.

agreed.

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:897: // TODO(oshima): support
SelectChar
jenny, while we're at it, can you file a bug for this feature and put reference
here?

[jennyz, 2011-12-16 17:10:19]

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:892:
OnKeyDown(ui::KeyboardCodeFromNative(xev));
On 2011/12/16 00:30:11, sky wrote:
> You should actually check the return value of OnKeyDown.

Done.

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:892:
OnKeyDown(ui::KeyboardCodeFromNative(xev));
On 2011/12/16 00:30:11, sky wrote:
> You should actually check the return value of OnKeyDown.

Done.

http://codereview.chromium.org/8965013/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:897: // TODO(oshima): support
SelectChar
On 2011/12/16 00:37:13, oshima wrote:
> jenny, while we're at it, can you file a bug for this feature and put
reference
> here?

Done.

[sky, 2011-12-16 17:22:16]

http://codereview.chromium.org/8965013/diff/4001/ui/views/controls/menu/menu_...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/4001/ui/views/controls/menu/menu_...
ui/views/controls/menu/menu_controller.cc:896: if (exit_type_ != EXIT_NONE)
This shouldn't be needed anymore.

[jennyz, 2011-12-16 17:29:30]

http://codereview.chromium.org/8965013/diff/4001/ui/views/controls/menu/menu_...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/4001/ui/views/controls/menu/menu_...
ui/views/controls/menu/menu_controller.cc:896: if (exit_type_ != EXIT_NONE)
On 2011/12/16 17:22:16, sky wrote:
> This shouldn't be needed anymore.

Done.

[sky, 2011-12-16 18:10:19]

LGTM

[oshima, 2011-12-16 18:21:32]

LGTM

http://codereview.chromium.org/8965013/diff/4/ui/views/controls/menu/menu_con...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/4/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:896: // See http://crbug.com/107869
nit: period at the end of both lines.

[jennyz, 2011-12-16 18:26:39]

http://codereview.chromium.org/8965013/diff/4/ui/views/controls/menu/menu_con...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/8965013/diff/4/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:896: // See http://crbug.com/107869
On 2011/12/16 18:21:33, oshima wrote:
> nit: period at the end of both lines.

Done.

[commit-bot: I haz the power, 2011-12-16 18:51:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/8965013/8001

[commit-bot: I haz the power, 2011-12-16 20:53:40]

Change committed as 114853