client/html/src/SVGSVGElementWrappingImplementation.dart - Issue 8965006: Support SVGElement#elements, #innerHTML, and #outerHTML. Also add a .svg constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/src/SVGSVGElementWrappingImplementation.dart

Issue 8965006: Support SVGElement#elements, #innerHTML, and #outerHTML. Also add a .svg constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« client/html/src/SVGElementWrappingImplementation.dart ('K') | « client/html/src/SVGElementWrappingImplementation.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/html/src/SVGSVGElementWrappingImplementation.dart

diff --git a/client/html/src/SVGSVGElementWrappingImplementation.dart b/client/html/src/SVGSVGElementWrappingImplementation.dart

index ca6ca99a477194bfc12fdbe4ab9fc5699246e433..a7efbe61dc5b9c78ba23b308e7b90f7a41d95526 100644

--- a/client/html/src/SVGSVGElementWrappingImplementation.dart

+++ b/client/html/src/SVGSVGElementWrappingImplementation.dart

@@ -8,7 +8,7 @@ class SVGSVGElementWrappingImplementation extends SVGElementWrappingImplementati

factory SVGSVGElementWrappingImplementation() {

var el = new SVGElement.tag("svg");

// The SVG spec requires the version attribute to match the spec version

- el.attributes['version'] = 1.1;

+ el.attributes['version'] = "1.1";

return el;

}