views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.h"
 
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/tab_contents/tab_contents_container.h"
 #include "chrome/browser/ui/views/tab_contents/tab_contents_view_views.h"
 #include "content/browser/tab_contents/interstitial_page.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "ui/aura/window.h"
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/focus/widget_focus_manager.h"
 #include "ui/views/views_delegate.h"
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTabContentsContainerAura, public:
 
 NativeTabContentsContainerAura::NativeTabContentsContainerAura(
     TabContentsContainer* container)
     : container_(container) {
   set_id(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW);
+  // We need to be focusable when our contents is not a view hierarchy, as
+  // clicking on the contents needs to focus us.
+  set_focusable(container_->tab_contents() != NULL);
 }
 
 NativeTabContentsContainerAura::~NativeTabContentsContainerAura() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTabContentsContainerAura, NativeTabContentsContainer overrides:
 
 void NativeTabContentsContainerAura::AttachContents(TabContents* contents) {
   // We need to register the tab contents window with the BrowserContainer so
@@ skipping 52 matching lines @@
     const views::KeyEvent& e) {
   // Don't look-up accelerators or tab-traversal if we are showing a non-crashed
   // TabContents.
   // We'll first give the page a chance to process the key events.  If it does
   // not process them, they'll be returned to us and we'll treat them as
   // accelerators then.
   return container_->tab_contents() &&
          !container_->tab_contents()->is_crashed();
 }
 
-bool NativeTabContentsContainerAura::IsFocusable() const {
-  // We need to be focusable when our contents is not a view hierarchy, as
-  // clicking on the contents needs to focus us.
-  return container_->tab_contents() != NULL;

[Ben Goodger (Google), 2011/12/15 21:21:41]

But can the TabContents become NULL at some point between the construction of
this object and someone calling IsFocusable()?

-}
-
 void NativeTabContentsContainerAura::OnFocus() {
   if (container_->tab_contents())
     container_->tab_contents()->Focus();
 }
 
 void NativeTabContentsContainerAura::RequestFocus() {
   // This is a hack to circumvent the fact that a the OnFocus() method is not
   // invoked when RequestFocus() is called on an already focused view.
   // The TabContentsContainer is the view focused when the TabContents has
   // focus.  When switching between from one tab that has focus to another tab
@@ skipping 28 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTabContentsContainer, public:
 
 // static
 NativeTabContentsContainer* NativeTabContentsContainer::CreateNativeContainer(
     TabContentsContainer* container) {
   return new NativeTabContentsContainerAura(container);
 }