Issue 8963016: Tell the linker in advance to expect a large output size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8963016: Tell the linker in advance to expect a large output size. (Closed)

Created:
9 years ago by Sigurður Ásgeirsson

Modified:
9 years ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, kareng_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tell the linker in advance to expect a large output size. This may reduce memory fragmentation, which may eke out a few more weeks of time on our official builds. Also turn down linker log verbosity. R=maruel@chromium.org BUG=None TEST=Official Windows build doesn't fail with linker OOM. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114808

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	build/internal/release_impl_official.gypi	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/8963016/diff/1/build/internal/release_impl_official.gypi File build/internal/release_impl_official.gypi (right): http://codereview.chromium.org/8963016/diff/1/build/internal/release_impl_official.gypi#newcode22 build/internal/release_impl_official.gypi:22: '/time', I didn't know this flag, cool.

9 years ago (2011-12-16 14:48:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/8963016/1

9 years ago (2011-12-16 14:52:37 UTC) #3

Change committed as 114808

Expand Messages | Collapse Messages