Add Double::NewCanonical and Mint::NewCanonical so that it is possible to

vm/object.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "vm/assert.h"
 #include "vm/dart.h"
 #include "vm/globals.h"
@@ skipping 590 matching lines @@
   }
   static intptr_t num_native_fields_offset() {
     return OFFSET_OF(RawClass, num_native_fields_);
   }
 
   RawCode* allocation_stub() const {
     return raw_ptr()->allocation_stub_;
   }
   void set_allocation_stub(const Code& value) const;
 
+  void set_constants(const Array& value) const;
+  RawArray* constants() const;
+
   void Finalize() const;
 
   // Allocate a class used for VM internal objects.
   template <class FakeObject> static RawClass* New();
 
   // Allocate an instance class which has a VM implementation.
   template <class FakeInstance> static RawClass* New(const String& name,
                                                      const Script& script);
 
   // Allocate instance classes and interfaces.
@@ skipping 18 matching lines @@
   // otherwise a new object is allocated and returned.
   static RawClass* GetClass(ObjectKind kind);
 
  private:
   void set_name(const String& value) const;
   void set_script(const Script& value) const;
   void set_signature_function(const Function& value) const;
   void set_signature_type(const AbstractType& value) const;
   void set_class_state(int8_t state) const;
 
-  void set_constants(const Array& value) const;
-  RawArray* constants() const;
-
   void set_canonical_types(const Array& value) const;
   RawArray* canonical_types() const;
 
   void CalculateFieldOffsets() const;
 
   // Check the subtype or assignability relationship.
   bool TestType(TypeTestKind test,
                 const AbstractTypeArguments& type_arguments,
                 const Class& other,
                 const AbstractTypeArguments& other_type_arguments) const;
@@ skipping 1686 matching lines @@
   }
 
   virtual bool Equals(const Instance& other) const;
 
   virtual double AsDoubleValue() const;
   virtual int64_t AsInt64Value() const;
 
   virtual int CompareWith(const Integer& other) const;
 
   static RawMint* New(int64_t value, Heap::Space space = Heap::kNew);
+  static RawMint* NewCanonical(int64_t value);
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawMint));
   }
 
  private:
   void set_value(int64_t value) const;
 
   HEAP_OBJECT_IMPLEMENTATION(Mint, Integer);
   friend class Class;
@@ skipping 58 matching lines @@
   friend class BigintOperations;
 };
 
 
 class Double : public Number {
  public:
   double value() const {
     return raw_ptr()->value_;
   }
 
+  bool Equals(double value) const;

[srdjan, 2011/12/15 22:02:26]

Please give this one a different name, e.g. EqualsToDouble, EqualsValue...

[siva, 2011/12/15 23:42:54]

Done.

+  virtual bool Equals(const Instance& other) const;
+
   static RawDouble* New(double d, Heap::Space space = Heap::kNew);
 
   static RawDouble* New(const String& str, Heap::Space space = Heap::kNew);
 
+  static RawDouble* NewCanonical(double d);

[srdjan, 2011/12/15 22:02:26]

Please use different names, e.g., NewCanonicalFromDouble,
NewCanonicalFromString.

[siva, 2011/12/15 23:42:54]

This style seems to go against the style we have used for New(...) methods
above.

On 2011/12/15 22:02:26, srdjan wrote:

+
+  static RawDouble* NewCanonical(const String& str);

[srdjan, 2011/12/15 22:02:26]

Need to comment that a Double::null() is returned if str does not contain a
double.

[siva, 2011/12/15 23:42:54]

Done.

+
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawDouble));
   }
 
   static intptr_t value_offset() { return OFFSET_OF(RawDouble, value_); }
 
  private:
   void set_value(double value) const;
 
   HEAP_OBJECT_IMPLEMENTATION(Double, Number);
@@ skipping 839 matching lines @@
 }
 
 
 void Context::SetAt(intptr_t index, const Instance& value) const {
   StorePointer(InstanceAddr(index), value.raw());
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_