Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 8962042: Add TYPE_INTEGER64 type to base::Value. (Closed)

Created:
9 years ago by kkania
Modified:
8 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Add TYPE_INTEGER64 type to base::Value. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -23 lines) Patch
M base/json/json_reader.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M base/json/json_reader_unittest.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M base/json/json_writer.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M base/json/json_writer_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M base/values.h View 9 chunks +13 lines, -1 line 0 comments Download
M base/values.cc View 10 chunks +58 lines, -3 lines 0 comments Download
M base/values_unittest.cc View 9 chunks +49 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kkania
This CL isn't for actual review yet. I would need to go through and fix ...
9 years ago (2011-12-23 00:19:47 UTC) #1
Nico
9 years ago (2011-12-23 00:24:40 UTC) #2
Hi,

I think this came up a few times on chromium-dev, here's one instance that I
found:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...

Usually, the conclusion is that javascript supports only doubles anyway, and
doubles have 53 bits of mantissa * 2^0, which is enough in practice. So can you
just use doubles for your use case?

Powered by Google App Engine
This is Rietveld 408576698