Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Issue 8962023: Roll the new Valgrind binaries with the movaps support. (Closed)

Created:
9 years ago by Alexander Potapenko
Modified:
9 years ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Visibility:
Public.

Description

Roll the new Valgrind binaries with the movaps support. This should make Webkit Layout bot happier. BUG=108424 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115695

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
TBR
9 years ago (2011-12-22 14:53:42 UTC) #1
Timur Iskhodzhanov
9 years ago (2011-12-22 17:31:15 UTC) #2
LGTM but please update the Mac binaries too (there were a few merges
between r126 and r130, right?).

On Thu, Dec 22, 2011 at 6:53 PM,  <glider@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Message:
> TBR
>
> Description:
> Roll the new Valgrind binaries with the movaps support.
> This should make Webkit Layout bot happier.
>
> BUG=108424
>
> Please review this at http://codereview.chromium.org/8962023/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
>
> Affected files:
>  M     README.chromium
>  M     binaries/linux_x64/lib/valgrind/memcheck-amd64-linux
>  M     binaries/linux_x64/lib/valgrind/memcheck-x86-linux
>  M     binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so
>  M     binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so
>  M     binaries/linux_x86/lib/valgrind/memcheck-x86-linux
>  M     binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so
>  M     scripts/build-memcheck-for-chromium.sh
>
>
> Index: README.chromium
> ===================================================================
> --- README.chromium     (revision 115535)
> +++ README.chromium     (working copy)
> @@ -1,7 +1,7 @@
>  Name: valgrind
>  Version: unknown
>
> -Memcheck version on Linux (valgrind-variant): 126
> +Memcheck version on Linux (valgrind-variant): 130
>  Memcheck version on Mac 10.5 (valgrind-variant): 123
>  Memcheck version on Mac 10.6 (valgrind-variant): 123
>
> Index: binaries/linux_x64/lib/valgrind/memcheck-amd64-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/memcheck-x86-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/lib/valgrind/memcheck-x86-linux
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: scripts/build-memcheck-for-chromium.sh
> ===================================================================
> --- scripts/build-memcheck-for-chromium.sh      (revision 115535)
> +++ scripts/build-memcheck-for-chromium.sh      (working copy)
> @@ -9,7 +9,7 @@
>  source $THISDIR/common.sh
>
>  # Use a fixed version of valgrind-variant.
> -MEMCHECK_VV_REV=126
> +MEMCHECK_VV_REV=130
>
>  VG_MEMCHECK_DIR="$VG_SRC_DIR/valgrind-memcheck"
>  checkout_and_patch_valgrind_variant "$MEMCHECK_VV_REV" "$VG_MEMCHECK_DIR"
>
>

Powered by Google App Engine
This is Rietveld 408576698