Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 8961023: Add media_constrained_network_perf to PYAUTO_TESTS. (Closed)

Created:
9 years ago by DaleCurtis
Modified:
9 years ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, John Grabowski, acolwell+watch_chromium.org, annacc+watch_chromium.org, dennis_jeffrey, anantha, dyu1, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org, shadi
Visibility:
Public.

Description

Add media_constrained_network_perf to PYAUTO_TESTS. As titled, introduces the a new media constrained network perf test into the PYAUTO_TESTS file. Also fixes incorrect flags on pyauto_media. BUG=106257, 106260 TEST=Ran local Buildbot, manual verification. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115247

Patch Set 1 #

Patch Set 2 : Typos. #

Patch Set 3 : Fixes. #

Patch Set 4 : Go for gold. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 2 3 1 chunk +1 line, -3 lines 1 comment Download
A chrome/test/functional/media/pyauto_media.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
DaleCurtis
9 years ago (2011-12-16 20:42:44 UTC) #1
imasaki1
On 2011/12/16 20:42:44, DaleCurtis wrote: I am just curious why you are not using PYAUTO ...
9 years ago (2011-12-16 20:49:05 UTC) #2
DaleCurtis
On 2011/12/16 20:49:05, imasaki1 wrote: > On 2011/12/16 20:42:44, DaleCurtis wrote: > > I am ...
9 years ago (2011-12-16 20:51:51 UTC) #3
Nirnimesh
On 2011/12/16 20:51:51, DaleCurtis wrote: > On 2011/12/16 20:49:05, imasaki1 wrote: > > On 2011/12/16 ...
9 years ago (2011-12-16 21:08:41 UTC) #4
DaleCurtis
On 2011/12/16 21:08:41, Nirnimesh wrote: > On 2011/12/16 20:51:51, DaleCurtis wrote: > > On 2011/12/16 ...
9 years ago (2011-12-16 21:39:12 UTC) #5
DaleCurtis
-cmp, since it's purely a config change now.
9 years ago (2011-12-16 22:17:24 UTC) #6
Nirnimesh
pyauto_media.py shows to me as empty http://codereview.chromium.org/8961023/diff/6001/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): http://codereview.chromium.org/8961023/diff/6001/chrome/test/functional/PYAUTO_TESTS#newcode609 chrome/test/functional/PYAUTO_TESTS:609: 'media.media_constrained_network_perf', So you ...
9 years ago (2011-12-17 00:10:47 UTC) #7
DaleCurtis
On 2011/12/17 00:10:47, Nirnimesh wrote: > pyauto_media.py shows to me as empty > > http://codereview.chromium.org/8961023/diff/6001/chrome/test/functional/PYAUTO_TESTS ...
9 years ago (2011-12-17 00:18:19 UTC) #8
Nirnimesh
LGTM
9 years ago (2011-12-17 21:45:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/8961023/6001
9 years ago (2011-12-20 23:28:03 UTC) #10
commit-bot: I haz the power
9 years ago (2011-12-21 01:03:35 UTC) #11
Change committed as 115247

Powered by Google App Engine
This is Rietveld 408576698