Clean up the Linux WebThemeEngine impl according to the coding style rules

Clean up the Linux WebThemeEngine impl according to the coding style rules

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115175

[Peter Beverloo, 2011-12-16 15:17:18]

As promised in CL 8889013.

gfx::NativeTheme occurs quite often as well (228 times in _win.cc, 31 times in
_linux.cc, 29 times in _android.cc), but I'm not sure about our usage of the
"using" directive.  Is there a preference as to after how many occurrences to
use it?

[darin (slow to review), 2011-12-16 18:01:02]

LGTM

We don't typically strip off the "gfx::" prefix.

http://codereview.chromium.org/8961013/diff/1/webkit/glue/webthemeengine_impl...
File webkit/glue/webthemeengine_impl_linux.cc (right):

http://codereview.chromium.org/8961013/diff/1/webkit/glue/webthemeengine_impl...
webkit/glue/webthemeengine_impl_linux.cc:179: static_cast<gfx::Rect>(rect),
nit: we usually just write gfx::Rect(rect) when we need to disambiguate.

[Peter Beverloo, 2011-12-19 15:38:03]

On 2011/12/16 18:01:02, darin wrote:
> LGTM
> 
> We don't typically strip off the "gfx::" prefix.

Alright, good to know.

> 
>
http://codereview.chromium.org/8961013/diff/1/webkit/glue/webthemeengine_impl...
> File webkit/glue/webthemeengine_impl_linux.cc (right):
> 
>
http://codereview.chromium.org/8961013/diff/1/webkit/glue/webthemeengine_impl...
> webkit/glue/webthemeengine_impl_linux.cc:179: static_cast<gfx::Rect>(rect),
> nit: we usually just write gfx::Rect(rect) when we need to disambiguate.

Done.

Thank you for the review, will land once the trybots happy.

[commit-bot: I haz the power, 2011-12-20 11:17:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/8961013/8001

[commit-bot: I haz the power, 2011-12-20 12:27:34]

Try job failure for 8961013-8001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-20 17:03:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/8961013/8001

[commit-bot: I haz the power, 2011-12-20 20:24:34]

Change committed as 115175