Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 8960010: base::Bind: Convert NewRunnableMethod in chrome/browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build fix 55. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_page_capture_api.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 6cdf208a32a797ceb69b78a2e675eba9018ea520..53e47f748b5e42a4ba31f6872747378bb4ac12aa 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -2815,24 +2815,22 @@ class ExtensionCookieCallback {
public:
ExtensionCookieCallback()
: result_(false),
- message_loop_factory_(MessageLoop::current()) {}
+ weak_factory_(MessageLoop::current()) {}
void SetCookieCallback(bool result) {
MessageLoop::current()->PostTask(
- FROM_HERE,
- message_loop_factory_.NewRunnableMethod(&MessageLoop::Quit));
+ FROM_HERE, base::Bind(&MessageLoop::Quit, weak_factory_.GetWeakPtr()));
result_ = result;
}
void GetAllCookiesCallback(const net::CookieList& list) {
MessageLoop::current()->PostTask(
- FROM_HERE,
- message_loop_factory_.NewRunnableMethod(&MessageLoop::Quit));
+ FROM_HERE, base::Bind(&MessageLoop::Quit, weak_factory_.GetWeakPtr()));
list_ = list;
}
net::CookieList list_;
bool result_;
- ScopedRunnableMethodFactory<MessageLoop> message_loop_factory_;
+ base::WeakPtrFactory<MessageLoop> weak_factory_;
};
// Verifies extension state is removed upon uninstall.
« no previous file with comments | « chrome/browser/extensions/extension_page_capture_api.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698