Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/x64/lithium-gap-resolver-x64.cc

Issue 8960004: Avoid embedding new space objects into code objects in the lithium gap resolver. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 __ movq(dst, kScratchRegister); 191 __ movq(dst, kScratchRegister);
192 } 192 }
193 193
194 } else if (source->IsConstantOperand()) { 194 } else if (source->IsConstantOperand()) {
195 LConstantOperand* constant_source = LConstantOperand::cast(source); 195 LConstantOperand* constant_source = LConstantOperand::cast(source);
196 if (destination->IsRegister()) { 196 if (destination->IsRegister()) {
197 Register dst = cgen_->ToRegister(destination); 197 Register dst = cgen_->ToRegister(destination);
198 if (cgen_->IsInteger32Constant(constant_source)) { 198 if (cgen_->IsInteger32Constant(constant_source)) {
199 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source))); 199 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source)));
200 } else { 200 } else {
201 __ Move(dst, cgen_->ToHandle(constant_source)); 201 __ LoadObject(dst, cgen_->ToHandle(constant_source));
202 } 202 }
203 } else { 203 } else {
204 ASSERT(destination->IsStackSlot()); 204 ASSERT(destination->IsStackSlot());
205 Operand dst = cgen_->ToOperand(destination); 205 Operand dst = cgen_->ToOperand(destination);
206 if (cgen_->IsInteger32Constant(constant_source)) { 206 if (cgen_->IsInteger32Constant(constant_source)) {
207 // Allow top 32 bits of an untagged Integer32 to be arbitrary. 207 // Allow top 32 bits of an untagged Integer32 to be arbitrary.
208 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source))); 208 __ movl(dst, Immediate(cgen_->ToInteger32(constant_source)));
209 } else { 209 } else {
210 __ Move(dst, cgen_->ToHandle(constant_source)); 210 __ LoadObject(kScratchRegister, cgen_->ToHandle(constant_source));
211 __ movq(dst, kScratchRegister);
211 } 212 }
212 } 213 }
213 214
214 } else if (source->IsDoubleRegister()) { 215 } else if (source->IsDoubleRegister()) {
215 XMMRegister src = cgen_->ToDoubleRegister(source); 216 XMMRegister src = cgen_->ToDoubleRegister(source);
216 if (destination->IsDoubleRegister()) { 217 if (destination->IsDoubleRegister()) {
217 __ movaps(cgen_->ToDoubleRegister(destination), src); 218 __ movaps(cgen_->ToDoubleRegister(destination), src);
218 } else { 219 } else {
219 ASSERT(destination->IsDoubleStackSlot()); 220 ASSERT(destination->IsDoubleStackSlot());
220 __ movsd(cgen_->ToOperand(destination), src); 221 __ movsd(cgen_->ToOperand(destination), src);
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 moves_[i].set_source(source); 312 moves_[i].set_source(source);
312 } 313 }
313 } 314 }
314 } 315 }
315 316
316 #undef __ 317 #undef __
317 318
318 } } // namespace v8::internal 319 } } // namespace v8::internal
319 320
320 #endif // V8_TARGET_ARCH_X64 321 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698