Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6965)

Unified Diff: chrome/common/extensions/api/experimental.downloads.json

Issue 8958023: Added missing names in extension api jsons (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed a typo Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/experimental.downloads.json
diff --git a/chrome/common/extensions/api/experimental.downloads.json b/chrome/common/extensions/api/experimental.downloads.json
index c60915ac27d326a6dc1d5857b223e106798b13c0..eca6731d4081a0c0d0ae392bb58b3f7278f64215 100644
--- a/chrome/common/extensions/api/experimental.downloads.json
+++ b/chrome/common/extensions/api/experimental.downloads.json
@@ -8,7 +8,7 @@
"type": "function",
"description": "This event fires with the DownloadItem object when a download begins.",
"parameters": [
- {"$ref": "DownloadItem"}
+ {"name": "downloadItem", "$ref": "DownloadItem"}
]
},
{
@@ -16,7 +16,7 @@
"type": "function",
"description": "When any of a DownloadItem's properties except |bytesReceived| changes, this event fires with the download id and an object containing the properties that changed.",
"parameters": [
- {"$ref": "DownloadDelta"}
+ {"name": "downloadDelta", "$ref": "DownloadDelta"}
]
},
{
@@ -435,7 +435,7 @@
"type": "function",
"description": "Download a URL. If the URL uses the HTTP[S] protocol, then the request will include all cookies currently set for its hostname. If the download started successfully, |callback| will be called with the new DownloadItem’s |id|. If there was an error starting the download, then |callback| will be called with |downloadId|=undefined and chrome.extension.lastError will be set. If the URL’s hostname is not specified in the |permissions| section of the extension’s manifest, then the |chrome.extensions.lastError| object will indicate that the extension does not have permission to access that hostname.",
"parameters": [
- {"$ref": "DownloadOptions"},
+ {"name": "options", "$ref": "DownloadOptions"},
{
"name": "callback",
"type": "function",
@@ -451,7 +451,7 @@
"type": "function",
"description": "Find DownloadItems. Set |query| to the empty object to get all DownloadItems. To get a specific DownloadItem, set only the |id| field.",
"parameters": [
- {"$ref": "DownloadQuery"},
+ {"name": "query", "$ref": "DownloadQuery"},
{
"name": "callback",
"type": "function",
@@ -467,7 +467,7 @@
"type": "function",
"description": "Erase matching DownloadItems from history",
"parameters": [
- {"$ref": "DownloadQuery"},
+ {"name": "query", "$ref": "DownloadQuery"},
{
"name": "callback",
"type": "function",

Powered by Google App Engine
This is Rietveld 408576698