Issue 8958023: Added missing names in extension api jsons

Issue 8958023: Added missing names in extension api jsons (Closed)

Created:
9 years ago by calamity

Modified:
8 years, 12 months ago

Reviewers:
Aaron Boodman, not at google - send to devlin

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Add missing names in extension api jsons so that code generation will work. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115776

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
M	chrome/common/extensions/api/contentSettings.json	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/experimental.bookmarkManager.json	View		6 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/api/experimental.downloads.json	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/api/experimental.input.ui.json	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/fileBrowserPrivate.json	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/mediaPlayerPrivate.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/omnibox.json	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/tabs.json	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/webNavigation.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 9 (0 generated)

not at google - send to devlin

@aa I guess this needs an extensions reviewer...

9 years ago (2011-12-23 00:04:55 UTC) #4

Aaron Boodman

LGTM On Thu, Dec 22, 2011 at 4:04 PM, <kalman@chromium.org> wrote: > @aa > > ...

9 years ago (2011-12-24 07:11:29 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/8958023/2001

9 years ago (2011-12-24 13:59:42 UTC) #6

commit-bot: I haz the power

Try job failure for 8958023-2001 (retry) on mac_rel for step "ui_tests". It's a second try, ...

9 years ago (2011-12-24 16:24:10 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/8958023/2001

8 years, 12 months ago (2011-12-25 11:55:29 UTC) #8

Change committed as 115776