Issue 8957009: Introduce --print-all-code flag and infrastructure for one flag to imply another flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8957009: Introduce --print-all-code flag and infrastructure for one flag to imply another flag. (Closed)

Created:
9 years ago by Yang

Modified:
9 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Introduce --print-all-code flag and infrastructure for one flag to imply another flag. Committed: http://code.google.com/p/v8/source/detail?r=10267

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -9 lines)			Patch
M	src/flag-definitions.h	View	7 chunks	+25 lines, -1 line	1 comment	Download
M	src/flags.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/flags.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/v8.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). http://codereview.chromium.org/8957009/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/8957009/diff/1/src/flag-definitions.h#newcode71 src/flag-definitions.h:71: #elif defined(FLAG_MODE_DEFINE_IMPLICATIONS) Can we add ...

9 years ago (2011-12-15 16:23:15 UTC) #2

Jakob Kummerow

9 years ago (2011-12-15 23:00:34 UTC) #3

Add DEFINE_implication(print_all_code, code_comments)? Pretty please?

Expand Messages | Collapse Messages