Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: media/audio/audio_input_unittest.cc

Issue 8957006: Remove the RecordWithSlowSink test. The test has problems running on the build bots and after di... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_input_unittest.cc
===================================================================
--- media/audio/audio_input_unittest.cc (revision 114624)
+++ media/audio/audio_input_unittest.cc (working copy)
@@ -190,34 +190,3 @@
ais->Stop();
ais->Close();
}
-
-// Test a recording sequence with delays in the audio callback.
-// TODO(joth): See bug 107546. This fails on slow bots. Once fixed, remove the
-// CHROME_HEADLESS check below.
-TEST(AudioInputTest, RecordWithSlowSink) {
- scoped_refptr<AudioManager> audio_man(AudioManager::Create());
- if (!CanRunAudioTests(audio_man.get()))
- return;
-
- scoped_ptr<base::Environment> env(base::Environment::Create());
- if (env->HasVar("CHROME_HEADLESS"))
- return;
-
- MessageLoop message_loop(MessageLoop::TYPE_DEFAULT);
- AudioInputStream* ais = CreateTestAudioInputStream(audio_man.get());
- EXPECT_TRUE(ais->Open());
-
- // We should normally get a callback every 50ms, and a 20ms delay inside each
- // callback should not change this sequence.
- TestInputCallbackBlocking test_callback(kSamplesPerPacket * 4, 0, 20);
- ais->Start(&test_callback);
- // Verify at least 500ms worth of audio was recorded, after giving sufficient
- // extra time.
- message_loop.PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), 590);
- message_loop.Run();
- EXPECT_GE(test_callback.callback_count(), 10);
- EXPECT_FALSE(test_callback.had_error());
-
- ais->Stop();
- ais->Close();
-}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698