Issue 8957005: Add X64 minidumps support to tools/grokdump.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8957005: Add X64 minidumps support to tools/grokdump.py (Closed)

Created:
9 years ago by Vyacheslav Egorov (Chromium)

Modified:
9 years ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add X64 minidumps support to tools/grokdump.py R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=10263

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -71 lines)			Patch
	M	tools/grokdump.py	View		18 chunks	+257 lines, -71 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years ago (2011-12-15 12:09:07 UTC) #2

LGTM

http://codereview.chromium.org/8957005/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

http://codereview.chromium.org/8957005/diff/1/tools/grokdump.py#newcode399
tools/grokdump.py:399: self.minidump, self.exception.thread_context.rva)
Do we output an error message if it's not one of those architectures, or do we
just silently fail?

Expand Messages | Collapse Messages