Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8957005: Add X64 minidumps support to tools/grokdump.py (Closed)

Created:
9 years ago by Vyacheslav Egorov (Chromium)
Modified:
9 years ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add X64 minidumps support to tools/grokdump.py R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=10263

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -71 lines) Patch
M tools/grokdump.py View 18 chunks +257 lines, -71 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years ago (2011-12-15 12:06:42 UTC) #1
Erik Corry
9 years ago (2011-12-15 12:09:07 UTC) #2
LGTM

http://codereview.chromium.org/8957005/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

http://codereview.chromium.org/8957005/diff/1/tools/grokdump.py#newcode399
tools/grokdump.py:399: self.minidump, self.exception.thread_context.rva)
Do we output an error message if it's not one of those architectures, or do we
just silently fail?

Powered by Google App Engine
This is Rietveld 408576698