Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 8956059: Rename NavigationController to NavigationControllerImpl and put it into the content namespace. Al... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler.h ('k') | chrome/browser/favicon/favicon_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler.cc
===================================================================
--- chrome/browser/favicon/favicon_handler.cc (revision 115900)
+++ chrome/browser/favicon/favicon_handler.cc (working copy)
@@ -21,6 +21,8 @@
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_util.h"
+using content::NavigationEntry;
+
namespace {
// Returns history::IconType the given icon_type corresponds to.
@@ -140,20 +142,20 @@
}
if (url == url_ && icon_type == history::FAVICON) {
- content::NavigationEntry* entry = GetEntry();
+ NavigationEntry* entry = GetEntry();
if (entry)
UpdateFavicon(entry, &sized_image);
}
}
-void FaviconHandler::UpdateFavicon(content::NavigationEntry* entry,
+void FaviconHandler::UpdateFavicon(NavigationEntry* entry,
scoped_refptr<RefCountedMemory> data) {
scoped_ptr<gfx::Image> image(gfx::ImageFromPNGEncodedData(data->front(),
data->size()));
UpdateFavicon(entry, image.get());
}
-void FaviconHandler::UpdateFavicon(content::NavigationEntry* entry,
+void FaviconHandler::UpdateFavicon(NavigationEntry* entry,
const gfx::Image* image) {
// No matter what happens, we need to mark the favicon as being set.
entry->GetFavicon().valid = true;
@@ -168,7 +170,7 @@
void FaviconHandler::OnUpdateFaviconURL(
int32 page_id,
const std::vector<FaviconURL>& candidates) {
- content::NavigationEntry* entry = GetEntry();
+ NavigationEntry* entry = GetEntry();
if (!entry)
return;
@@ -245,8 +247,8 @@
download_requests_.erase(i);
}
-content::NavigationEntry* FaviconHandler::GetEntry() {
- content::NavigationEntry* entry = delegate_->GetActiveEntry();
+NavigationEntry* FaviconHandler::GetEntry() {
+ NavigationEntry* entry = delegate_->GetActiveEntry();
if (entry && entry->GetURL() == url_)
return entry;
@@ -313,7 +315,7 @@
void FaviconHandler::OnFaviconDataForInitialURL(
FaviconService::Handle handle,
history::FaviconData favicon) {
- content::NavigationEntry* entry = GetEntry();
+ NavigationEntry* entry = GetEntry();
if (!entry)
return;
@@ -390,7 +392,7 @@
void FaviconHandler::OnFaviconData(FaviconService::Handle handle,
history::FaviconData favicon) {
- content::NavigationEntry* entry = GetEntry();
+ NavigationEntry* entry = GetEntry();
if (!entry)
return;
« no previous file with comments | « chrome/browser/favicon/favicon_handler.h ('k') | chrome/browser/favicon/favicon_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698