Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8956019: base::Bind: Remove includes of base.bind in header files. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
wtc, awong
CC:
chromium-reviews, vrk (LEFT CHROMIUM), nkostylev+watch_chromium.org, acolwell+watch_chromium.org, achuith+watch_chromium.org, amit, wtc, mihaip+watch_chromium.org, cbentzel+watch_chromium.org, tbarzic+watch_chromium.org, jam, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, tim (not reviewing), ihf+watch_chromium.org, jstritar+watch_chromium.org, sanjeevr, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, rkn, ncarter (slow), dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, erikwright (departed), garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, robertshield, Paweł Hajdan Jr., Randy Smith (Not in Mondays)
Visibility:
Public.

Description

base::Bind: Remove includes of base.bind in header files. BUG=none TEST=none R=ajwong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115398

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing file. #

Patch Set 3 : Mac fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -53 lines) Patch
M base/threading/post_task_and_reply_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_storage_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/sqlite_origin_bound_cert_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/weak_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/weak_handle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/custom_sync_call_context.h View 3 chunks +6 lines, -32 lines 0 comments Download
A chrome_frame/custom_sync_call_context.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M content/browser/geolocation/device_data_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/download_rate_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/download_rate_monitor_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/cookie_store_test_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/cookie_store_test_helpers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/default_origin_bound_cert_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/scoped_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/scoped_thread_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_mac.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
9 years ago (2011-12-20 02:14:05 UTC) #1
awong
http://codereview.chromium.org/8956019/diff/1/chrome_frame/custom_sync_call_context.h File chrome_frame/custom_sync_call_context.h (right): http://codereview.chromium.org/8956019/diff/1/chrome_frame/custom_sync_call_context.h#newcode21 chrome_frame/custom_sync_call_context.h:21: typedef Tuple4<HWND, HWND, int, int> output_type; We missing a ...
9 years ago (2011-12-20 02:16:36 UTC) #2
James Hawkins
http://codereview.chromium.org/8956019/diff/1/chrome_frame/custom_sync_call_context.h File chrome_frame/custom_sync_call_context.h (right): http://codereview.chromium.org/8956019/diff/1/chrome_frame/custom_sync_call_context.h#newcode21 chrome_frame/custom_sync_call_context.h:21: typedef Tuple4<HWND, HWND, int, int> output_type; On 2011/12/20 02:16:36, ...
9 years ago (2011-12-20 02:17:51 UTC) #3
awong
LGTM
9 years ago (2011-12-20 02:20:47 UTC) #4
wtc
9 years ago (2011-12-20 19:00:17 UTC) #5 
Patch Set 3 LGTM.

I only reviewed the files in net and chrome/browser/net.

Powered by Google App Engine
This is Rietveld 408576698