Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: dart/frog/presubmit.py

Issue 8956012: Make --leg-only option work when there are arguments passed to test.py. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « dart/client/tests/client/client.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 2 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
3 # for details. All rights reserved. Use of this source code is governed by a 3 # for details. All rights reserved. Use of this source code is governed by a
4 # BSD-style license that can be found in the LICENSE file. 4 # BSD-style license that can be found in the LICENSE file.
5 5
6 import optparse 6 import optparse
7 import os 7 import os
8 import stat 8 import stat
9 import subprocess 9 import subprocess
10 import sys 10 import sys
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 if not options.leg_only: 112 if not options.leg_only:
113 SelfHost() 113 SelfHost()
114 114
115 RunCommand('../tools/build.py', '--mode=release') 115 RunCommand('../tools/build.py', '--mode=release')
116 test_cmd = ['../tools/test.py', '--report', '--timeout=30', 116 test_cmd = ['../tools/test.py', '--report', '--timeout=30',
117 '--progress=color', '--mode=release', '--checked'] 117 '--progress=color', '--mode=release', '--checked']
118 118
119 if options.notest: return 119 if options.notest: return
120 120
121 if args: 121 if args:
122 test_cmd.append('--component=frogsh,leg') 122 if options.leg_only:
123 test_cmd.append('--component=leg')
124 else:
125 test_cmd.append('--component=frogsh,leg')
123 test_cmd.extend(args) 126 test_cmd.extend(args)
124 RunCommand(*test_cmd, verbose=True) 127 RunCommand(*test_cmd, verbose=True)
125 else: 128 else:
126 if not options.leg_only: 129 if not options.leg_only:
127 # Run frog.py on the corelib tests, so we get some frog.py coverage. 130 # Run frog.py on the corelib tests, so we get some frog.py coverage.
128 cmd = test_cmd + ['--component=frog', 'corelib'] 131 cmd = test_cmd + ['--component=frog', 'corelib']
129 RunCommand(*cmd, verbose=True) 132 RunCommand(*cmd, verbose=True)
130 133
131 # Run frogium client tests. This is a pretty quick test but 134 # Run frogium client tests. This is a pretty quick test but
132 # tends to uncover different issues due to the size/complexity 135 # tends to uncover different issues due to the size/complexity
(...skipping 13 matching lines...) Expand all
146 cmd = test_cmd + ['--component=leg', 149 cmd = test_cmd + ['--component=leg',
147 'language', 'corelib', 'leg', 'leg_only'] 150 'language', 'corelib', 'leg', 'leg_only']
148 RunCommand(*cmd, verbose=True) 151 RunCommand(*cmd, verbose=True)
149 152
150 if __name__ == '__main__': 153 if __name__ == '__main__':
151 try: 154 try:
152 sys.exit(main()) 155 sys.exit(main())
153 except Error as e: 156 except Error as e:
154 sys.stderr.write('%s\n' % e) 157 sys.stderr.write('%s\n' % e)
155 sys.exit(1) 158 sys.exit(1)
OLDNEW
« no previous file with comments | « dart/client/tests/client/client.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698