Issue 8954018: Fix AuthErrorTest for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8954018: Fix AuthErrorTest for Mac (Closed)

Created:
9 years ago by Raghu Simha

Modified:
9 years ago

Reviewers:
lipalani1

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix AuthErrorTest for Mac The sync integration test for auth errors was failing on the mac buildbots. It turns out that this was due to keychain prompts on mac, as we were trying to add a password form, due to a known issue with mac keychain. This patch switches the datatype used by the auth error test to bookmarks, so that this test can be reenabled. The underlying issue with keychain will be fixed in another patch. BUG=107611 TEST=SyncErrorTest.AuthErrorTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114669

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -22 lines)			Patch
	M	chrome/browser/sync/test/integration/sync_errors_test.cc	View		2 chunks	+7 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!!

Expand Messages | Collapse Messages