Issue 8954017: Avoid including gtest file directly, and go through base instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8954017: Avoid including gtest file directly, and go through base instead (Closed)

Created:
9 years ago by jar (doing other things)

Modified:
9 years ago

Reviewers:
brettw

CC:
chromium-reviews, michaeln, jstritar+watch_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, ncarter (slow), Raghu Simha, amit, mihaip+watch_chromium.org, Aaron Boodman, robertshield, tim (not reviewing), brettw-cc_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, akalin

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Avoid including gtest file directly, and go through base instead We should consistently: #include "base/gtest_prod_util.h" which does the gtest include (from the right place, in a second repo, hidden in our tree). This is critical to being able to supplant the FRIEND_TEST macro, which we're experimenting with to optimize builds. r=brettw TBR=other owners (this is a trivial change) BUG=107727 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114685

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_controller.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/language_switch_menu.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/component_loader.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/in_memory_url_index.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/http_bridge.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/urlmon_url_request_private.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/base/xmpp_connection.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	net/disk_cache/mem_entry_impl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/socks5_client_socket.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_service.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

In all cases, we now include the same gtest file indirectly instead of directly. In ...

9 years ago (2011-12-15 18:03:59 UTC) #1

lgtm

Expand Messages | Collapse Messages

Issue 8954017: Avoid including gtest file directly, and go through base instead (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages