Do not pass the deprecated -fasan flag in the asan=1 mode

Do not pass the deprecated -fasan flag in the asan=1 mode
(we're already passing -faddress-sanitizer).
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115097

[Alexander Potapenko, 2011-12-19 15:15:49]

Please take a look

[Nico, 2011-12-19 17:36:58]

Lgtm
On Dec 19, 2011 7:15 AM, <glider@chromium.org> wrote:

> Reviewers: Nico,
>
> Message:
> Please take a look
>
> Description:
> Do not pass the deprecated -fasan flag in the asan=1 mode
> (we're already passing -faddress-sanitizer).
>
> Please review this at
http://codereview.chromium.**org/8953033/<http://codereview.chromium.org/8953...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     build/common.gypi
>
>
> Index: build/common.gypi
> ==============================**==============================**=======
> --- build/common.gypi   (revision 114969)
> +++ build/common.gypi   (working copy)
> @@ -1976,15 +1976,11 @@
>             ],
>           }],
>           ['asan==1', {
> -            # TODO(glider): -fasan is deprecated. Remove it when we stop
> using
> -            # it.
>             'cflags': [
> -              '-fasan',
>               '-faddress-sanitizer',
>               '-w',
>             ],
>             'ldflags': [
> -              '-fasan',
>               '-faddress-sanitizer',
>             ],
>             'defines': [
> @@ -2339,12 +2335,10 @@
>           ['asan==1', {
>             'xcode_settings': {
>               'OTHER_CFLAGS': [
> -                '-fasan',
>                 '-faddress-sanitizer',
>                 '-w',
>               ],
>               'OTHER_LDFLAGS': [
> -                '-fasan',
>                 '-faddress-sanitizer',
>                 # The symbols below are referenced in the ASan runtime
>                 # library (compiled on OS X 10.6), but may be unavailable
>
>
>