Pepper: unit tests for VarTracker

Pepper: unit tests for VarTracker

BUG=none
TEST=ppapi_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114778

[Takashi Toyoshima, 2011-12-15 14:37:38]

Hi, this is unit tests for VarTracker!
Could you review these tests?

[brettw, 2011-12-15 16:58:44]

lgtm

http://codereview.chromium.org/8953017/diff/1/ppapi/shared_impl/var_tracker_u...
File ppapi/shared_impl/var_tracker_unittest.cc (right):

http://codereview.chromium.org/8953017/diff/1/ppapi/shared_impl/var_tracker_u...
ppapi/shared_impl/var_tracker_unittest.cc:95: TEST_F(VarTrackerTest,
GetResourceRefAgain) {
Can you substitute every time you say "Resource" in the test names and comments
with "Plugin". A resource is actually a different type of object so it could be
confusing.

[Takashi Toyoshima, 2011-12-16 04:28:45]

Thank you for correcting my wrong usage of the term.

http://codereview.chromium.org/8953017/diff/1/ppapi/shared_impl/var_tracker_u...
File ppapi/shared_impl/var_tracker_unittest.cc (right):

http://codereview.chromium.org/8953017/diff/1/ppapi/shared_impl/var_tracker_u...
ppapi/shared_impl/var_tracker_unittest.cc:95: TEST_F(VarTrackerTest,
GetResourceRefAgain) {
On 2011/12/15 16:58:45, brettw wrote:
> Can you substitute every time you say "Resource" in the test names and
comments
> with "Plugin". A resource is actually a different type of object so it could
be
> confusing.

Done.

[commit-bot: I haz the power, 2011-12-16 04:29:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8953017/5001

[commit-bot: I haz the power, 2011-12-16 04:49:42]

Try job failure for 8953017-5001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Takashi Toyoshima, 2011-12-16 05:21:38]

Wow, now trunk tree has GetPPVar() implementation in class Var,
and the interface become non-virtual.
So I just remove GetPPVar() from class MockObjectVar.

[commit-bot: I haz the power, 2011-12-16 05:22:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8953017/7002

[commit-bot: I haz the power, 2011-12-16 07:10:01]

Change committed as 114778