Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 8953006: Free the command buffer when tabs are switched (Closed)

Created:
9 years ago by greggman
Modified:
9 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Free the command buffer when tabs are switched GLES2Implemetation::FreeEverything now fress everything it can. the transfer buffer, the command buffer and any unused mapped buffer (glMapSubXXX). BUG=103989 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114602

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -66 lines) Patch
M gpu/command_buffer/client/cmd_buffer_helper.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.cc View 9 chunks +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 9 chunks +47 lines, -21 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/ring_buffer_test.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 4 chunks +11 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hi Al, here's another CL when you get a chance.
9 years ago (2011-12-15 01:12:00 UTC) #1
apatrick_chromium
lgtm
9 years ago (2011-12-15 01:30:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8953006/15
9 years ago (2011-12-15 04:25:07 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-15 05:38:00 UTC) #4
Change committed as 114602

Powered by Google App Engine
This is Rietveld 408576698