Issue 8953004: Now that the launcher is sized to the width of the root window we need

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8953004: Now that the launcher is sized to the width of the root window we need (Closed)

Created:
9 years ago by sky

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, Paweł Hajdan Jr., sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Now that the launcher is sized to the width of the root window we need to tell it the size of the launcher so that it doesn't layout on top of the status. BUG=106432 TEST=covered by tests. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114658

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -31 lines)			Patch
M	ui/aura_shell/aura_shell.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.cc	View		3 chunks	+88 lines, -3 lines	0 comments	Download
A	ui/aura_shell/launcher/launcher_unittest.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.cc	View		3 chunks	+0 lines, -24 lines	0 comments	Download
M	ui/aura_shell/shelf_layout_manager.h	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	ui/aura_shell/shelf_layout_manager.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/aura_shell/shelf_layout_manager_unittest.cc	View		2 chunks	+26 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8953004/2001

9 years ago (2011-12-15 16:23:37 UTC) #3

Change committed as 114658