client/html/release/htmlimpl.dart - Issue 8953001: Cleaner and more correct fix for _ChildrenNodeList#forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/release/htmlimpl.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 8953001: Cleaner and more correct fix for _ChildrenNodeList#forEach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: client/html/release/htmlimpl.dart

diff --git a/client/html/release/htmlimpl.dart b/client/html/release/htmlimpl.dart

index 13dc71d298c18f4d6942442281459ac2babd1a70..64ec2916bdb15650d21860e1afa1257bd08e923d 100644

--- a/client/html/release/htmlimpl.dart

+++ b/client/html/release/htmlimpl.dart

@@ -23890,11 +23890,7 @@ class _ChildrenNodeList implements NodeList {

return LevelDom.wrapNode(_node.firstChild);

}

- void forEach(void f(Node element)) {

- for (int i = 0, len = _childNodes.length; i < len; i++) {

- f(LevelDom.wrapNode(_childNodes[i]));

- }

+ void forEach(void f(Node element)) => _toList().forEach(f);

Collection<Node> filter(bool f(Node element)) {

List<Node> output = new List<Node>();

« no previous file with comments | « no previous file | client/html/src/NodeWrappingImplementation.dart » ('j') | no next file with comments »