Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 8952028: Make Runtime_Apply safer. (Closed)

Created:
8 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make Runtime_Apply safer. There is a call to Object::GetElement that could conceivably cause a GC. Handlify all raw pointer local variables. R=vegorov@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M src/runtime.cc View 3 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
8 years, 11 months ago (2012-01-02 15:17:07 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-02 15:19:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698