Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 8952022: Add TimeDelay interfaces to TestTimeouts. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add TimeDelay interfaces to TestTimeouts. R=brettw@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116194

Patch Set 1 #

Total comments: 1

Patch Set 2 : Explicitly qualify namespace of TimeDelta. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M base/test/test_timeouts.h View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ted Vessenes
8 years, 11 months ago (2012-01-02 02:05:27 UTC) #1
Ted Vessenes
It seemed pretty clear to me that this class should define TimeDelta interfaces. But do ...
8 years, 11 months ago (2012-01-02 22:34:41 UTC) #2
brettw
I don't think we should have two versions of the functions. http://codereview.chromium.org/8952022/diff/1/base/test/test_timeouts.h File base/test/test_timeouts.h (right): ...
8 years, 11 months ago (2012-01-03 05:38:48 UTC) #3
Ted Vessenes
Sorry about that; the 'using' statement is a bit new to me, but upon reflection ...
8 years, 11 months ago (2012-01-03 15:14:17 UTC) #4
brettw
lgtm
8 years, 11 months ago (2012-01-03 17:40:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/8952022/6001
8 years, 11 months ago (2012-01-03 17:43:59 UTC) #6
commit-bot: I haz the power
Try job failure for 8952022-6001 (retry) on mac_rel for step "ui_tests" (clobber build). It's a ...
8 years, 11 months ago (2012-01-03 19:28:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/8952022/6001
8 years, 11 months ago (2012-01-03 19:49:30 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-03 21:04:07 UTC) #9
Change committed as 116194

Powered by Google App Engine
This is Rietveld 408576698