Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 8951014: Change the DidChangeView update to take a new ViewChanged resource. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: New patch Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/plugin.h
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.h b/ppapi/native_client/src/trusted/plugin/plugin.h
index d713de7dc9d6a3f0c2fddf0e792276831321f76b..cb91d0ec1c6b9f82e23cd09fb348d269b1bd8c85 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.h
+++ b/ppapi/native_client/src/trusted/plugin/plugin.h
@@ -33,6 +33,7 @@
#include "ppapi/cpp/rect.h"
#include "ppapi/cpp/url_loader.h"
#include "ppapi/cpp/var.h"
+#include "ppapi/cpp/view.h"
struct NaClSrpcChannel;
@@ -84,7 +85,7 @@ class Plugin : public pp::InstancePrivate {
virtual bool Init(uint32_t argc, const char* argn[], const char* argv[]);
// Handles view changes from the browser.
- virtual void DidChangeView(const pp::Rect& position, const pp::Rect& clip);
+ virtual void DidChangeView(const pp::View& view);
// Handles gaining or losing focus.
virtual void DidChangeFocus(bool has_focus);
@@ -512,15 +513,14 @@ class Plugin : public pp::InstancePrivate {
bool enable_dev_interfaces_;
// If we get a DidChangeView event before the nexe is loaded, we store it and
- // replay it to nexe after it's loaded.
- bool replayDidChangeView;
- pp::Rect replayDidChangeViewPosition;
- pp::Rect replayDidChangeViewClip;
+ // replay it to nexe after it's loaded. We need to replay when this View
+ // resource is non-is_null().
+ pp::View view_to_replay_;
// If we get a HandleDocumentLoad event before the nexe is loaded, we store
- // it and replay it to nexe after it's loaded.
- bool replayHandleDocumentLoad;
- pp::URLLoader replayHandleDocumentLoadURLLoader;
+ // it and replay it to nexe after it's loaded. We need to replay when this
+ // URLLoader resource is non-is_null().
+ pp::URLLoader document_load_to_replay_;
nacl::string mime_type_;

Powered by Google App Engine
This is Rietveld 408576698