Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2475)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.h

Issue 8951014: Change the DidChangeView update to take a new ViewChanged resource. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: New patch Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/nacl_process_host.h
diff --git a/chrome/browser/nacl_host/nacl_process_host.h b/chrome/browser/nacl_host/nacl_process_host.h
index 265e34fc26c876ad21f702a2ea6c887bf1fd460b..6641c49e11e43b8b7676292505379ae9b5d2a8d2 100644
--- a/chrome/browser/nacl_host/nacl_process_host.h
+++ b/chrome/browser/nacl_host/nacl_process_host.h
@@ -31,7 +31,10 @@ class NaClProcessHost : public BrowserChildProcessHost {
// Do any minimal work that must be done at browser startup.
static void EarlyStartup();
- // Initialize the new NaCl process, returning true on success.
+ // Initialize the new NaCl process, returning true on success. On success,
+ // the NaCl process host will assume responsibility for sending the reply
+ // message. On failure, the reply will not be sent and this is the caller's
+ // responsibility to avoid handling the renderer.
dmichael (off chromium) 2011/12/20 19:01:34 "avoid handling the renderer"? Is it supposed to s
bool Launch(ChromeRenderMessageFilter* chrome_render_message_filter,
int socket_count,
IPC::Message* reply_msg);
@@ -62,7 +65,9 @@ class NaClProcessHost : public BrowserChildProcessHost {
// this for sending the reply once the process has started.
scoped_refptr<ChromeRenderMessageFilter> chrome_render_message_filter_;
- // The reply message to send.
+ // The reply message to send. We must always send this message when the
+ // sub-process either succeeds or fails to unblock the renderer waiting for
+ // the reply. NULL when there is no reply to send.
IPC::Message* reply_msg_;
// Socket pairs for the NaCl process and renderer.
« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | chrome/browser/nacl_host/nacl_process_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698