Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: ppapi/native_client/tests/ppapi_browser/ppp_instance/ppapi_ppp_instance.cc

Issue 8951014: Change the DidChangeView update to take a new ViewChanged resource. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More nacl fixes Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/ppapi_browser/ppp_instance/ppapi_ppp_instance.cc
diff --git a/ppapi/native_client/tests/ppapi_browser/ppp_instance/ppapi_ppp_instance.cc b/ppapi/native_client/tests/ppapi_browser/ppp_instance/ppapi_ppp_instance.cc
index d00f2ae3d7501752fb5283467303ca5497e01cac..f77d58bcb4261332e4b0ec76bee1c1667e36aa1b 100644
--- a/ppapi/native_client/tests/ppapi_browser/ppp_instance/ppapi_ppp_instance.cc
+++ b/ppapi/native_client/tests/ppapi_browser/ppp_instance/ppapi_ppp_instance.cc
@@ -14,6 +14,7 @@
#include "ppapi/c/pp_bool.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/pp_input_event.h"
+#include "ppapi/c/ppb_view.h"
#include "ppapi/c/ppp_instance.h"
namespace {
@@ -37,15 +38,19 @@ void DidDestroy(PP_Instance instance) {
NACL_NOTREACHED();
}
-void DidChangeView(PP_Instance instance,
- const struct PP_Rect* position,
- const struct PP_Rect* clip) {
+void DidChangeView(PP_Instance instance, PP_Resource view) {
printf("--- PPP_Instance::DidChangeView\n");
EXPECT(instance == pp_instance());
- EXPECT(clip->point.x == 0 && clip->point.y == 0);
+
+ PP_Rect clip;
+ PPBView()->GetClipRect(view, &clip);
+ EXPECT(clip.point.x == 0 && clip.point.y == 0);
+
// These are based on embed dimensions.
- EXPECT(position->size.width == 15 && clip->size.width == 15);
- EXPECT(position->size.height == 20 && clip->size.height == 20);
+ PP_Rect position;
+ PPBView()->GetRect(view, &position);
+ EXPECT(position.size.width == 15 && clip.size.width == 15);
+ EXPECT(position.size.height == 20 && clip.size.height == 20);
TEST_PASSED;
}

Powered by Google App Engine
This is Rietveld 408576698