Change the DidChangeView update to take a new ViewChanged resource.

chrome/browser/nacl_host/nacl_process_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/nacl_host/nacl_process_host.h"
 
 #if defined(OS_POSIX)
 #include <fcntl.h>
@@ skipping 209 matching lines @@
     internal_->sockets_for_renderer.push_back(pair[0]);
     internal_->sockets_for_sel_ldr.push_back(pair[1]);
     SetCloseOnExec(pair[0]);
     SetCloseOnExec(pair[1]);
   }
 
   // Launch the process
   if (!LaunchSelLdr()) {
     return false;
   }
+
   chrome_render_message_filter_ = chrome_render_message_filter;
+
+  // On success, we take responsibility for sending the reply.
   reply_msg_ = reply_msg;
-
   return true;
 }
 
 bool NaClProcessHost::LaunchSelLdr() {
   std::string channel_id = child_process_host()->CreateChannel();
   if (channel_id.empty())
     return false;
 
   CommandLine::StringType nacl_loader_prefix;
 #if defined(OS_POSIX)
@@ skipping 133 matching lines @@
 }
 
 void NaClProcessHost::OnProcessLaunched() {
   NaClBrowser* nacl_browser = NaClBrowser::GetInstance();
 
   if (nacl_browser->IrtAvailable()) {
     // The IRT is already open.  Away we go.
     SendStart(nacl_browser->IrtFile());
   } else {
     // We're waiting for the IRT to be open.
-    nacl_browser->MakeIrtAvailable(base::Bind(&NaClProcessHost::IrtReady,
-                                              weak_factory_.GetWeakPtr()));
+    if (!nacl_browser->MakeIrtAvailable(
+            base::Bind(&NaClProcessHost::IrtReady,
+                       weak_factory_.GetWeakPtr())))
+      delete this;

[dmichael (off chromium), 2011/12/20 19:01:34]

I'm a little uneasy about "delete this" here, especially with this being a
virtual function. Not really for a technical reason, but because it's another
level of indirection and it seems like it could be a maintenance problem if the
caller doesn't know that OnProcessLaunched can result in the pointer being
invalidated.

Maybe it would make sense to make OnProcessLaunched return a bool indicating
success, and then on failure, you can delete it here:
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/browser/brows...

(But I'm new to this part of the code, so you can ignore me if you're sure this
is not going to be a problem).

[brettw, 2011/12/21 22:06:54]

Sorry this shouldn't have been in this CL (got two mixed up). Sadly, "delete
this" is how this component works.

   }
 }
 
 // The asynchronous attempt to get the IRT file open has completed.
 void NaClProcessHost::IrtReady() {
   NaClBrowser* nacl_browser = NaClBrowser::GetInstance();
 
   if (nacl_browser->IrtAvailable()) {
     SendStart(nacl_browser->IrtFile());
   } else {
@@ skipping 136 matching lines @@
 #endif
 
   Send(new NaClProcessMsg_Start(handles_for_sel_ldr));
   internal_->sockets_for_sel_ldr.clear();
 }
 
 bool NaClProcessHost::OnMessageReceived(const IPC::Message& msg) {
   NOTREACHED() << "Invalid message with type = " << msg.type();
   return false;
 }