Change the DidChangeView update to take a new ViewChanged resource.

ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_instance.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "native_client/src/shared/ppapi_proxy/browser_ppp_instance.h"
 
 #include <stdio.h>
 #include <string.h>
 #include <limits>
 
 #include "native_client/src/include/checked_cast.h"
 #include "native_client/src/include/nacl_scoped_ptr.h"
 #include "native_client/src/include/portability.h"
 #include "native_client/src/shared/ppapi_proxy/browser_globals.h"
 #include "native_client/src/shared/ppapi_proxy/browser_ppp.h"
 #include "native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppp_rpc.h"
 #include "native_client/src/shared/ppapi_proxy/utility.h"
+#include "native_client/src/shared/ppapi_proxy/view_data.h"
 #include "ppapi/c/pp_resource.h"
 #include "ppapi/c/pp_var.h"
 #include "ppapi/c/ppp_instance.h"
+#include "ppapi/c/ppb_view.h"
 
 using nacl::scoped_array;
+using ppapi_proxy::ViewData;
 
 namespace ppapi_proxy {
 
 namespace {
 
 char* ArgArraySerialize(int argc,
                         const char* array[],
                         uint32_t* serial_size) {
   uint32_t used = 0;
   for (int i = 0; i < argc; ++i) {
@@ skipping 60 matching lines @@
 }
 
 void DidDestroy(PP_Instance instance) {
   DebugPrintf("PPP_Instance::DidDestroy: instance=%"NACL_PRIu32"\n", instance);
   NaClSrpcError srpc_result = PppInstanceRpcClient::PPP_Instance_DidDestroy(
       GetMainSrpcChannel(instance), instance);
   DebugPrintf("PPP_Instance::DidDestroy: %s\n",
               NaClSrpcErrorString(srpc_result));
 }
 
-void DidChangeView(PP_Instance instance,
-                   const PP_Rect* position,
-                   const PP_Rect* clip) {
+void DidChangeView(PP_Instance instance, PP_Resource view) {
   DebugPrintf("PPP_Instance::DidChangeView: instance=%"NACL_PRIu32"\n",
               instance);
-  int32_t position_array[4];
-  const uint32_t kPositionArraySize = NACL_ARRAY_SIZE(position_array);
-  position_array[0] = position->point.x;
-  position_array[1] = position->point.y;
-  position_array[2] = position->size.width;
-  position_array[3] = position->size.height;
-  int32_t clip_array[4];
-  const uint32_t kClipArraySize = NACL_ARRAY_SIZE(clip_array);
-  clip_array[0] = clip->point.x;
-  clip_array[1] = clip->point.y;
-  clip_array[2] = clip->size.width;
-  clip_array[3] = clip->size.height;
+  ViewData view_data;
+
+  // We only send the new view info. The plugin side keeps track of the
+  // previous state it sent out, so can do the "changed" part itself.
+  const PPB_View* view_interface = static_cast<const PPB_View*>(
+      GetBrowserInterface(PPB_VIEW_INTERFACE));
+  view_interface->GetRect(view, &view_data.viewport_rect);
+  view_data.is_fullscreen = view_interface->IsFullscreen(view);
+  view_data.is_page_visible = view_interface->IsPageVisible(view);
+  view_interface->GetClipRect(view, &view_data.clip_rect);
+
   NaClSrpcError srpc_result = PppInstanceRpcClient::PPP_Instance_DidChangeView(
       GetMainSrpcChannel(instance),
       instance,
-      kPositionArraySize,
-      position_array,
-      kClipArraySize,
-      clip_array,
-      static_cast<int32_t>(PPBFullscreenInterface()->IsFullscreen(instance)));
+      view,
+      sizeof(ViewData),
+      reinterpret_cast<char*>(&view_data));
   DebugPrintf("PPP_Instance::DidChangeView: %s\n",
               NaClSrpcErrorString(srpc_result));
 }
 
 void DidChangeFocus(PP_Instance instance, PP_Bool has_focus) {
   DebugPrintf("PPP_Instance::DidChangeFocus: instance=%"NACL_PRIu32", "
               "has_focus = %d\n", instance, has_focus);
   NaClSrpcError srpc_result = PppInstanceRpcClient::PPP_Instance_DidChangeFocus(
       GetMainSrpcChannel(instance),
       instance,
@@ skipping 28 matching lines @@
     DidCreate,
     DidDestroy,
     DidChangeView,
     DidChangeFocus,
     HandleDocumentLoad
   };
   return &instance_interface;
 }
 
 }  // namespace ppapi_proxy