Remove bogus writability check in DefineGetterSetter.

Remove bogus writability check in DefineGetterSetter.

R=rossberg@chromium.org
TEST=test262

Committed: http://code.google.com/p/v8/source/detail?r=10269

[Michael Starzinger, 2011-12-15 15:35:48]

Another three down.

[rossberg, 2011-12-16 12:03:36]

http://codereview.chromium.org/8951013/diff/1/src/objects.cc
File src/objects.cc (left):

http://codereview.chromium.org/8951013/diff/1/src/objects.cc#oldcode4272
src/objects.cc:4272: if (details.IsReadOnly()) return heap->undefined_value();
IsReadOnly clearly is the wrong check here. But I suggest adding a check for
IsConfigurable (as an assertion?).

Please also document configurability as a pre-condition.

[Michael Starzinger, 2011-12-16 12:38:02]

PTAQL.

http://codereview.chromium.org/8951013/diff/1/src/objects.cc
File src/objects.cc (left):

http://codereview.chromium.org/8951013/diff/1/src/objects.cc#oldcode4272
src/objects.cc:4272: if (details.IsReadOnly()) return heap->undefined_value();
On 2011/12/16 12:03:36, rossberg wrote:
> IsReadOnly clearly is the wrong check here. But I suggest adding a check for
> IsConfigurable (as an assertion?).
> 
> Please also document configurability as a pre-condition.

Done. As discussed offline: The correct check here would be to check for
details.IsDontDelete() and return undefined if the property is non-deletable.
But since we call into the runtime twice (once for getter and once for setter),
we cannot do that yet. Left a TODO comment that explains the situation.

We should define both (getter and setter) in one single runtime call and then
add the correct check here.

[rossberg, 2011-12-16 12:39:21]

lgtm