Issue 8951011: Add presubmit checks for TSan suppressions

Issue 8951011: Add presubmit checks for TSan suppressions (Closed)

Created:
9 years ago by Timur Iskhodzhanov

Modified:
9 years ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Reid Kleckner

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add presubmit checks for TSan suppressions TEST=`gclient presubmit cl` with different errors in tools/valgrind/tsan/suppressions.txt Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114629

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -30 lines)			Patch
M	tools/valgrind/suppressions.py	View	1 2 3 4	7 chunks	+75 lines, -24 lines	0 comments	Download
M	tools/valgrind/tsan/PRESUBMIT.py	View	1 2 3	1 chunk	+21 lines, -0 lines	0 comments	Download
M	tools/valgrind/tsan/suppressions.txt	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Alexander: please review Reid: heads up, you'll need to rebase

9 years ago (2011-12-15 12:56:56 UTC) #1

Alexander Potapenko

http://codereview.chromium.org/8951011/diff/2001/tools/valgrind/suppressions.py File tools/valgrind/suppressions.py (right): http://codereview.chromium.org/8951011/diff/2001/tools/valgrind/suppressions.py#newcode248 tools/valgrind/suppressions.py:248: known_supp_names[s.description].defined_at), pls fix the indentation http://codereview.chromium.org/8951011/diff/2001/tools/valgrind/suppressions.py#newcode273 tools/valgrind/suppressions.py:273: "Suppression:\n%s\ndid match ...

9 years ago (2011-12-15 13:07:23 UTC) #2

Timur Iskhodzhanov

PTAL http://codereview.chromium.org/8951011/diff/2001/tools/valgrind/suppressions.py File tools/valgrind/suppressions.py (right): http://codereview.chromium.org/8951011/diff/2001/tools/valgrind/suppressions.py#newcode248 tools/valgrind/suppressions.py:248: known_supp_names[s.description].defined_at), On 2011/12/15 13:07:23, Alexander Potapenko wrote: > ...

9 years ago (2011-12-15 13:17:27 UTC) #3

Alexander Potapenko

9 years ago (2011-12-15 13:35:31 UTC) #4

lgtm

http://codereview.chromium.org/8951011/diff/2002/tools/valgrind/suppressions.py
File tools/valgrind/suppressions.py (right):

http://codereview.chromium.org/8951011/diff/2002/tools/valgrind/suppressions....
tools/valgrind/suppressions.py:279: 
Please add a blank line, as this is a top-level definition.

Expand Messages | Collapse Messages