Issue 8951009: Update the images used for HTML speech input to lower contrast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8951009: Update the images used for HTML speech input to lower contrast. (Closed)

Created:
9 years ago by dmazzoni

Modified:
9 years ago

Reviewers:
tony, Satish

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Satish

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Update the images used for HTML speech input to lower contrast. Temporarily suppress 4 tests that will fail until rebaselined. BUG=107668 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114698

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -21 lines)			Patch
M	webkit/glue/resources/input_speech.png	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
M	webkit/glue/resources/input_speech_recording.png	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
M	webkit/glue/resources/input_speech_waiting.png	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

9 years ago (2011-12-15 18:31:24 UTC) #2

LGTM with the following change.  You may also want to run pngcrush or pngslim on
the png files to make them as small as possible.

http://codereview.chromium.org/8951009/diff/1/webkit/tools/layout_tests/test_...
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/8951009/diff/1/webkit/tools/layout_tests/test_...
webkit/tools/layout_tests/test_expectations.txt:10: BUG_DMAZZONI:
fast/speech/input-appearance-numberandspeech.html = IMAGE
Please make these BUGCR107668.

Expand Messages | Collapse Messages