Issue 8951008: Move chrome zoom constants into their own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8951008: Move chrome zoom constants into their own file. (Closed)

Created:
9 years ago by Lei Zhang

Modified:
9 years ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move chrome zoom constants into their own file. BUG=107063 TEST=none TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114611

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -75 lines)			Patch
M	chrome/browser/chrome_page_zoom.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chrome_page_zoom.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
A +	chrome/browser/chrome_page_zoom_constants.h	View	2 chunks	+4 lines, -14 lines	0 comments	Download
A +	chrome/browser/chrome_page_zoom_constants.cc	View	1 chunk	+1 line, -49 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Testing this on Windows right now. Will commit this and the corresponding PDF change as ...

9 years ago (2011-12-15 06:12:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8951008/1

9 years ago (2011-12-15 08:58:59 UTC) #2

commit-bot: I haz the power

9 years ago (2011-12-15 08:59:04 UTC) #3

Can't apply patch for file chrome/browser/chrome_page_zoom_constants.cc.
While running patch -p0 --forward --force;
patching file chrome/browser/chrome_page_zoom_constants.cc
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/chrome_page_zoom_constants.cc.rej

Expand Messages | Collapse Messages