Issue 8949069: Remove references to headers not in TC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8949069: Remove references to headers not in TC. (Closed)

Created:
9 years ago by noelallen1

Modified:
8 years, 12 months ago

Reviewers:
dmichael (off chromium), Roland McGrath

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove references to headers not in TC. Currently we copy headers to a location in the toolchain during build which do not actually belong there. This CL converts the toolchain relative paths to NaCl repo relative in preparation for the removal of those headers. BUG= http://code.google.com/p/chromium/issues/detail?id=108503 TEST= try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115922

Patch Set 1 #

Patch Set 2 : '' #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
M	ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_example_audio/audio.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_simple_tests/audio.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_simple_tests/file.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	ppapi/native_client/tests/ppapi_simple_tests/graphics2d.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

8 years, 12 months ago (2011-12-28 22:19:21 UTC) #3

LGTM

FYI for BUG=: You can just provide the bug number for chromium bugs, no need to
do the whole link.
FYI for TEST=: This is actually meant to be instructions for the QA team, if
such instructions are necessary. In this case, you can leave it blank or mark it
N/A

Expand Messages | Collapse Messages