Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4739)

Unified Diff: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc

Issue 8949056: This adds support for encrypted ONC import (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More Review Changes Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
diff --git a/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc b/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
index 40158f9b60959bd72ee189d2f532238c3456651f..ea68b558fdcf97898b7976f3af6565b13848428e 100644
--- a/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
+++ b/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
@@ -259,7 +259,7 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkWifi1) {
" }"
" }]"
"}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
EXPECT_EQ(1, parser.GetNetworkConfigsSize());
EXPECT_EQ(0, parser.GetCertificatesSize());
@@ -277,6 +277,42 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkWifi1) {
CheckStringProperty(wifi, PROPERTY_INDEX_PASSPHRASE, "pass");
}
+TEST_F(OncNetworkParserTest, TestLoadEncryptedOnc) {
+ std::string test_blob(
+ "{"
+ " \"IV\": \"gQY+S44xHuIvATPYoSkx8A==\","
+ " \"Salt\": \"tX5gQnnxWMg=\","
+ " \"Cipher\": \"AES256\","
+ " \"Stretch\": \"PBKDF2\","
+ " \"HMACMethod\": \"SHA1\","
+ " \"HMAC\": \"s9671bsjZm7cWX2KtDTWa1G3Ee4=\","
+ " \"Iterations\": 10000,"
+ " \"Ciphertext\": \"iGV7M4usugq9JxD4qULtxyGgdbFitRqNLIVIjGmImWHGbaF7G"
+ "EVZmDRoDtHOypAwbEYEHzDrHAqv/8WGNb5WvuLIl36VR1IuqL+OeRmljCN9ylMkrZfydj"
+ "mVI35OHapwonGdWZdPQCVq+7/YL7OC7sfwVTYpbcnPN3+qznDOFc9BMvgdXyEbJIBzk0A"
+ "nt6BSw0a1tGhSXQ0tguq+VGlbIcvW8eeuCrNQkf1JY7RSrHadWjcgLnrlbvD4qIfrYrRi"
+ "rnlH8dmb6vlpJ5iToRslh1SKoKAOlpyxBmp1Vn8uGSIb8XPnJGxrN2Ke/E40m7d5GpdN4"
+ "1TjvH0rY4Zqlnp5uP/PT+XB2IGsnFamLZv8yEiw6gZim26VG+nZeWcruXJELLPLPwEaAk"
+ "4jTpEEDW56mT1nXc3ak0bj5y8zzoCQMWO8vwHZ55zvyKTEw78EvhoI\""
+ "}");
+ OncNetworkParser parser(test_blob,
+ "test0000",
+ NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ ASSERT_TRUE(parser.parse_error().empty());
+ EXPECT_EQ(1, parser.GetNetworkConfigsSize());
+ EXPECT_EQ(0, parser.GetCertificatesSize());
+ Network* network = parser.ParseNetwork(0);
+ ASSERT_TRUE(network);
+
+ EXPECT_EQ(network->type(), chromeos::TYPE_WIFI);
+ WifiNetwork* wifi = static_cast<WifiNetwork*>(network);
+ EXPECT_EQ(wifi->encryption(), chromeos::SECURITY_NONE);
+ EXPECT_EQ(wifi->name(), "WirelessNetwork");
+ EXPECT_EQ(wifi->auto_connect(), false);
+ EXPECT_EQ(wifi->passphrase(), "");
+}
+
+
TEST_F(OncNetworkParserTest, TestCreateNetworkWifiEAP1) {
std::string test_blob(
"{"
@@ -294,7 +330,7 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkWifiEAP1) {
" }"
" }]"
"}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
EXPECT_EQ(1, parser.GetNetworkConfigsSize());
EXPECT_EQ(0, parser.GetCertificatesSize());
@@ -333,7 +369,7 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkWifiEAP2) {
" }"
" }]"
"}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
EXPECT_EQ(1, parser.GetNetworkConfigsSize());
EXPECT_EQ(0, parser.GetCertificatesSize());
@@ -372,7 +408,7 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkUnknownFields) {
" },"
" }]"
"}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
scoped_ptr<Network> network(parser.ParseNetwork(0));
ASSERT_TRUE(network.get());
@@ -389,7 +425,7 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkOpenVPN) {
" \"NetworkConfigurations\": [") +
std::string(kNetworkConfigurationOpenVPN) + std::string(
" ]}"));
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
EXPECT_EQ(1, parser.GetNetworkConfigsSize());
EXPECT_EQ(0, parser.GetCertificatesSize());
@@ -468,7 +504,7 @@ TEST_F(OncNetworkParserTest, TestCreateNetworkL2TPIPsec) {
" ],"
" \"Certificates\": []"
"}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
EXPECT_EQ(1, parser.GetNetworkConfigsSize());
EXPECT_EQ(0, parser.GetCertificatesSize());
@@ -534,7 +570,7 @@ TEST_F(OncNetworkParserTest, TestAddClientCertificate) {
" ],"
"}");
std::string test_guid("{f998f760-272b-6939-4c2beffe428697ac}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
ASSERT_EQ(1, parser.GetCertificatesSize());
scoped_refptr<net::X509Certificate> cert = parser.ParseCertificate(0).get();
@@ -604,7 +640,7 @@ TEST_F(OncNetworkParserTest, TestAddServerCertificate) {
" ],"
"}");
std::string test_guid("{f998f760-272b-6939-4c2beffe428697aa}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
ASSERT_EQ(1, parser.GetCertificatesSize());
scoped_refptr<net::X509Certificate> cert = parser.ParseCertificate(0).get();
@@ -635,7 +671,7 @@ TEST_F(OncNetworkParserTest, TestAddAuthorityCertificate) {
" ],"
"}"));
std::string test_guid("{f998f760-272b-6939-4c2beffe428697ab}");
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
ASSERT_EQ(1, parser.GetCertificatesSize());
scoped_refptr<net::X509Certificate> cert = parser.ParseCertificate(0).get();
@@ -668,7 +704,7 @@ TEST_F(OncNetworkParserTest, TestNetworkAndCertificate) {
std::string(kCertificateWebAuthority) + std::string(
" ],"
"}"));
- OncNetworkParser parser(test_blob, NetworkUIData::ONC_SOURCE_USER_IMPORT);
+ OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
EXPECT_EQ(1, parser.GetCertificatesSize());
EXPECT_TRUE(parser.ParseCertificate(0));

Powered by Google App Engine
This is Rietveld 408576698