Issue 250: Allow for GNU formatted errors

compiler/java/com/google/dart/compiler/CommandLineOptions.java

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler;
 
 import com.google.common.collect.Lists;
+import com.google.dart.compiler.CompilerConfiguration.ErrorFormat;
 import com.google.dart.runner.DartRunner;
 import com.google.dart.runner.RunnerOptions;
 
 import org.kohsuke.args4j.Argument;
 import org.kohsuke.args4j.CmdLineException;
 import org.kohsuke.args4j.CmdLineParser;
 import org.kohsuke.args4j.Option;
 
 import java.io.File;
 import java.util.ArrayList;
@@ skipping 16 matching lines @@
         usage = "Batch mode (for unit testing)")
     private boolean batch = false;
 
     @Option(name = "--check-only", aliases = { "-check-only" },
         usage = "Do not generate output, only analyze")
     private boolean checkOnly = false;
 
     @Option(name = "--expose_core_impl", usage = "Automatic import of dart:coreimpl library")
     private boolean exposeCoreImpl = false;
 
-    @Option(name = "--machine-problems",
-        usage = "Format errors for machine parsing")
-    private boolean printMachineProblems = false;
+    @Option(name = "--error_format",
+        usage = "Format errors as normal, machine, or GNU")

[zundel, 2011/12/22 15:32:31]

remove gnu

[codefu, 2011/12/22 15:38:20]

Done.

+    private String errorFormat = "";
 
     @Option(name = "--enable_type_checks",
         usage = "Generate runtime type checks")
     private boolean developerModeChecks = false;
 
     @Option(name = "--disable-type-optimizations",
         usage = "Turn off type optimizations\n (for debugging)")
     private boolean disableTypeOptimizations = false;
 
     @Option(name = "--documentation-lib", aliases = { "-documentation-lib" },
@@ skipping 230 matching lines @@
 
     public boolean showJvmMetrics() {
       return showJvmMetrics;
     }
 
     public boolean showMetrics() {
       return showMetrics;
     }
 
     /**
-     * Returns <code>true</code> if the compiler should print compilation problems in machine
-     * format, with all information - severity, subsystem, etc.
-     */
-    public boolean printMachineProblems() {
-      return printMachineProblems;
-    }
-
-    /**
      * Returns whether type errors are fatal.
      */
     public boolean typeErrorsAreFatal() {
       return typeErrorsAreFatal;
     }
 
     /**
      * Returns whether warnings (excluding type warnings) are fatal.
      */
     public boolean warningsAreFatal() {
       return warningsAreFatal;
     }
 
     public boolean developerModeChecks() {
       return developerModeChecks;
     }
+
+    /**
+     * @return the format to use for printing errors
+     */
+    public ErrorFormat printErrorFormat() {
+      String lowerError = errorFormat.toLowerCase();
+      if ("machine".equals(lowerError)) {
+        return ErrorFormat.MACHINE;
+      }
+      return ErrorFormat.NORMAL;
+    }
   }
 
   /**
    * Command line options accepted by the {@link DartRunner} entry point.
    */
   public static class DartRunnerOptions extends CompilerOptions implements RunnerOptions {
 
     @Option(name = "--compile-only", usage = "Compile but do not execute")
     private boolean compileOnly = false;
 
@@ skipping 91 matching lines @@
           args = newArgs.toArray(new String[newArgs.size()]);
           cmdLineParser = new CmdLineParser(parsedOptions);
           continue;
         }
       }
       break;
     }
     return cmdLineParser;
   }
 }