Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: vm/class_finalizer.cc

Issue 8949043: - Fix outdated use of factory clause. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/class_finalizer.h ('k') | vm/custom_isolate_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/class_finalizer.cc
===================================================================
--- vm/class_finalizer.cc (revision 2706)
+++ vm/class_finalizer.cc (working copy)
@@ -73,7 +73,7 @@
}
ResolveSuperType(cls);
if (cls.is_interface()) {
- ResolveFactoryClass(cls);
+ ResolveDefaultClass(cls);
}
}
// Finalize all classes.
@@ -350,7 +350,7 @@
}
-void ClassFinalizer::ResolveFactoryClass(const Class& interface) {
+void ClassFinalizer::ResolveDefaultClass(const Class& interface) {
ASSERT(interface.is_interface());
if (interface.is_finalized() ||
!interface.HasFactoryClass() ||
@@ -369,7 +369,7 @@
const String& factory_name = String::Handle(factory_class.Name());
const Script& script = Script::Handle(interface.script());
ReportError(script, unresolved_factory_class.token_index(),
- "factory clause of interface '%s' names non-class '%s'.\n",
+ "default clause of interface '%s' names non-class '%s'.\n",
interface_name.ToCString(),
factory_name.ToCString());
}
@@ -390,7 +390,7 @@
const String& factory_name = String::Handle(factory_class.Name());
const Script& script = Script::Handle(interface.script());
ReportWarning(script, unresolved_factory_class.token_index(),
- "class '%s' in factory clause of interface '%s' is "
+ "class '%s' in default clause of interface '%s' is "
"missing its type parameter list.\n",
factory_name.ToCString(),
interface_name.ToCString());
« no previous file with comments | « vm/class_finalizer.h ('k') | vm/custom_isolate_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698