frog/leg/resolver.dart - Issue 8949039: Make sure a class is resolved before looking up its elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/leg/resolver.dart

Issue 8949039: Make sure a class is resolved before looking up its elements. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/leg/resolver.dart

===================================================================

--- frog/leg/resolver.dart (revision 2693)

+++ frog/leg/resolver.dart (working copy)

@@ -308,7 +308,7 @@

return null;

} else if (receiver.kind === ElementKind.CLASS) {

ClassElement receiverClass = receiver;

- target = receiverClass.lookupLocalElement(name);

+ target = receiverClass.resolve(compiler).lookupLocalElement(name);

ngeoffray 2011/12/21 13:17:06 I will deal with lookupLocalElement -> lookupEleme

if (target == null) {

error(node, MessageKind.METHOD_NOT_FOUND, [receiver, name]);

} else if (target.isInstanceMember()) {

@@ -412,10 +412,7 @@

if (cls !== null) {

// TODO(ngeoffray): set constructor-name correctly.

SourceString name = cls.name;

- // TODO(ngeoffray): define what isResolved means. Also, pass the

- // needed element to resolve?

- if (!cls.isResolved) compiler.resolveType(cls);

- constructor = cls.lookupLocalElement(name);

+ constructor = cls.resolve(compiler).lookupLocalElement(name);

if (name == cls.name

&& constructor === null

&& node.send.argumentsNode.isEmpty()) {

« no previous file with comments | « frog/leg/elements/elements.dart ('k') | frog/tests/leg_only/src/StaticField2Test.dart » ('j') | no next file with comments »