tools/testing/dart/test_runner.dart - Issue 8949034: Fix test.dart by not closing processes twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8949034: Fix test.dart by not closing processes twice. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index 947c624f33477e371e261bb4913cf26037f7bb77..8cef5a5f2915c39d6bdd32fd950efabe1a346132 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -185,10 +185,10 @@ class RunningProcess {

}

void compilerExitHandler(int exitCode) {

- process.close();

if (exitCode != 0) {

exitHandler(exitCode);

} else {

+ process.close();

runCommand(testCase.executablePath, testCase.arguments, exitHandler);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »