Issue 8949010: Rename WindowDragDropDelegate->DragDropDelegate

Issue 8949010: Rename WindowDragDropDelegate->DragDropDelegate (Closed)

Created:
9 years ago by Ben Goodger (Google)

Modified:
9 years ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, dhollowa+watch_chromium.org, Paweł Hajdan Jr., dcheng, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Rename WindowDragDropDelegate->DragDropDelegate Move D&D client stuff into client namespace. Provide some convenient getters/setters. BUG=none TEST=existing automation TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114595

Patch Set 1 : '' #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -120 lines)			Patch
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc	View	1	5 chunks	+9 lines, -20 lines	0 comments	Download
M	ui/aura/aura.gyp	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/aura/client/drag_drop_client.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
A	ui/aura/client/drag_drop_client.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A +	ui/aura/client/drag_drop_delegate.h	View		2 chunks	+12 lines, -6 lines	0 comments	Download
A	ui/aura/client/drag_drop_delegate.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download
D	ui/aura/client/window_drag_drop_delegate.h	View	1	1 chunk	+0 lines, -43 lines	0 comments	Download
M	ui/aura_shell/drag_drop_controller.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/aura_shell/drag_drop_controller.cc	View	1	5 chunks	+10 lines, -17 lines	0 comments	Download
M	ui/aura_shell/drag_drop_controller_unittest.cc	View	1	2 chunks	+7 lines, -15 lines	0 comments	Download
M	ui/aura_shell/shell.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8949010/5034

9 years ago (2011-12-15 04:56:56 UTC) #2

commit-bot: I haz the power

Can't apply patch for file ui/aura/client/drag_drop_delegate.h. While running patch -p0 --forward --force; patching file ui/aura/client/drag_drop_delegate.h ...

9 years ago (2011-12-15 04:57:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8949010/2010

9 years ago (2011-12-15 05:00:04 UTC) #4

commit-bot: I haz the power

Can't apply patch for file ui/aura/client/drag_drop_delegate.h. While running patch -p0 --forward --force; patching file ui/aura/client/drag_drop_delegate.h ...

9 years ago (2011-12-15 05:00:08 UTC) #5

LGTM

Expand Messages | Collapse Messages