Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: webkit/appcache/appcache_storage_impl_unittest.cc

Issue 8949001: Fix some loose ends around recently introduced AppCache INTERCEPT namespaces (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_storage_impl_unittest.cc
===================================================================
--- webkit/appcache/appcache_storage_impl_unittest.cc (revision 116156)
+++ webkit/appcache/appcache_storage_impl_unittest.cc (working copy)
@@ -95,13 +95,13 @@
}
void OnMainResponseFound(const GURL& url, const AppCacheEntry& entry,
- const GURL& fallback_url,
+ const GURL& namespace_entry_url,
const AppCacheEntry& fallback_entry,
int64 cache_id, int64 group_id,
const GURL& manifest_url) {
found_url_ = url;
found_entry_ = entry;
- found_fallback_url_ = fallback_url;
+ found_namespace_entry_url_ = namespace_entry_url;
found_fallback_entry_ = fallback_entry;
found_cache_id_ = cache_id;
found_group_id_ = group_id;
@@ -121,7 +121,7 @@
bool obsoleted_success_;
GURL found_url_;
AppCacheEntry found_entry_;
- GURL found_fallback_url_;
+ GURL found_namespace_entry_url_;
AppCacheEntry found_fallback_entry_;
int64 found_cache_id_;
int64 found_group_id_;
@@ -807,7 +807,7 @@
EXPECT_EQ(kNoCacheId, delegate()->found_cache_id_);
EXPECT_EQ(kNoResponseId, delegate()->found_entry_.response_id());
EXPECT_EQ(kNoResponseId, delegate()->found_fallback_entry_.response_id());
- EXPECT_TRUE(delegate()->found_fallback_url_.is_empty());
+ EXPECT_TRUE(delegate()->found_namespace_entry_url_.is_empty());
EXPECT_EQ(0, delegate()->found_entry_.types());
EXPECT_EQ(0, delegate()->found_fallback_entry_.types());
TestFinished();
@@ -926,7 +926,7 @@
EXPECT_EQ(2, delegate()->found_group_id_);
EXPECT_FALSE(delegate()->found_entry_.has_response_id());
EXPECT_EQ(2, delegate()->found_fallback_entry_.response_id());
- EXPECT_EQ(kEntryUrl2, delegate()->found_fallback_url_);
+ EXPECT_EQ(kEntryUrl2, delegate()->found_namespace_entry_url_);
EXPECT_TRUE(delegate()->found_fallback_entry_.IsFallback());
TestFinished();
}
@@ -995,6 +995,7 @@
EXPECT_EQ(2, delegate()->found_group_id_);
EXPECT_EQ(2, delegate()->found_entry_.response_id());
EXPECT_TRUE(delegate()->found_entry_.IsIntercept());
+ EXPECT_EQ(kEntryUrl2, delegate()->found_namespace_entry_url_);
EXPECT_FALSE(delegate()->found_fallback_entry_.has_response_id());
TestFinished();
}
@@ -1125,7 +1126,7 @@
EXPECT_EQ(3 + kFallbackEntryIdOffset,
delegate()->found_fallback_entry_.response_id());
EXPECT_TRUE(delegate()->found_fallback_entry_.IsFallback());
- EXPECT_EQ(kEntryUrl2, delegate()->found_fallback_url_);
+ EXPECT_EQ(kEntryUrl2, delegate()->found_namespace_entry_url_);
// Conduct another test preferring kManifestUrl2 that hits the fallback.
delegate_.reset(new MockStorageDelegate(this));
@@ -1146,7 +1147,7 @@
EXPECT_EQ(2 + kFallbackEntryIdOffset,
delegate()->found_fallback_entry_.response_id());
EXPECT_TRUE(delegate()->found_fallback_entry_.IsFallback());
- EXPECT_EQ(kEntryUrl2, delegate()->found_fallback_url_);
+ EXPECT_EQ(kEntryUrl2, delegate()->found_namespace_entry_url_);
TestFinished();
}
@@ -1213,7 +1214,7 @@
EXPECT_EQ(0, delegate()->found_group_id_);
EXPECT_EQ(kNoResponseId, delegate()->found_entry_.response_id());
EXPECT_EQ(kNoResponseId, delegate()->found_fallback_entry_.response_id());
- EXPECT_TRUE(delegate()->found_fallback_url_.is_empty());
+ EXPECT_TRUE(delegate()->found_namespace_entry_url_.is_empty());
EXPECT_EQ(0, delegate()->found_entry_.types());
EXPECT_EQ(0, delegate()->found_fallback_entry_.types());

Powered by Google App Engine
This is Rietveld 408576698