Issue 8949001: Fix some loose ends around recently introduced AppCache INTERCEPT namespaces

Issue 8949001: Fix some loose ends around recently introduced AppCache INTERCEPT namespaces (Closed)

Created:
9 years ago by michaeln

Modified:
8 years, 11 months ago

Reviewers:
jennb

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix some loose ends around recently introduced AppCache INTERCEPT namespaces - if an intercept entry cant be fetched, the appcache update should fail - properly mark the intercept entry as FORIEGN when thats detected BUG=101565 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116417

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -115 lines)			Patch
M	webkit/appcache/appcache.h	View	1 2 3 4 5	3 chunks	+13 lines, -4 lines	0 comments	Download
M	webkit/appcache/appcache.cc	View	1 2 3 4 5 6	3 chunks	+9 lines, -6 lines	0 comments	Download
M	webkit/appcache/appcache_entry.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/appcache/appcache_host.h	View	1 2 3 4 5	2 chunks	+6 lines, -5 lines	0 comments	Download
M	webkit/appcache/appcache_host.cc	View	1 2 3 4 5	3 chunks	+7 lines, -5 lines	0 comments	Download
M	webkit/appcache/appcache_host_unittest.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_request_handler.h	View	1 2 3 4 5	2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/appcache/appcache_request_handler.cc	View	1 2 3 4 5	6 chunks	+10 lines, -10 lines	0 comments	Download
M	webkit/appcache/appcache_request_handler_unittest.cc	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/appcache/appcache_storage.h	View	1 2 3 4 5	1 chunk	+5 lines, -2 lines	1 comment	Download
M	webkit/appcache/appcache_storage_impl.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_storage_impl.cc	View	1 2 3 4 5	5 chunks	+13 lines, -12 lines	0 comments	Download
M	webkit/appcache/appcache_storage_impl_unittest.cc	View	1 2 3 4 5	8 chunks	+9 lines, -8 lines	0 comments	Download
M	webkit/appcache/appcache_unittest.cc	View	1 2 3 4 5 6	8 chunks	+42 lines, -11 lines	0 comments	Download
M	webkit/appcache/appcache_update_job.cc	View	1 2 3 4 5	3 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/appcache/mock_appcache_storage.cc	View	1 2 3 4 5	8 chunks	+75 lines, -42 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

hi jenn, can you also take a look at this follow up CL?

8 years, 11 months ago (2012-01-04 20:39:46 UTC) #1

jennb

lgtm http://codereview.chromium.org/8949001/diff/19002/webkit/appcache/appcache_storage.h File webkit/appcache/appcache_storage.h (right): http://codereview.chromium.org/8949001/diff/19002/webkit/appcache/appcache_storage.h#newcode64 webkit/appcache/appcache_storage.h:64: // and fallback_entry.response_id() will be kNoResponseId. extra 'and'

8 years, 11 months ago (2012-01-04 22:12:14 UTC) #2

> extra 'and'

thnx, done

Expand Messages | Collapse Messages