Updates dartc to recognize 'default' keyword on interface and updated factory method syntax

compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 package com.google.dart.compiler.resolver;
 
 import com.google.common.base.Joiner;
 import com.google.dart.compiler.CompilerTestCase;
 import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.ast.DartNewExpression;
 import com.google.dart.compiler.ast.DartNode;
@@ skipping 267 matching lines @@
                 "  foo() {",
                 "    new I(0);",
                 "    new I.foo(0);",
                 "  }",
                 "}"));
     // Check errors.
     {
       List<DartCompilationError> errors = libraryResult.getCompilationErrors();
       assertErrors(
           errors,
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_UNRESOLVED, 2, 3, 9),
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_UNRESOLVED, 3, 3, 13),
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_UNRESOLVED, 10, 9, 1),
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_UNRESOLVED, 11, 9, 5));
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_UNRESOLVED, 2, 3, 9),
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_UNRESOLVED, 3, 3, 13),
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_UNRESOLVED, 10, 9, 1),
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_UNRESOLVED, 11, 9, 5));
       {
         String message = errors.get(0).getMessage();
         assertTrue(message, message.contains("'F'"));
         assertTrue(message, message.contains("'F'"));
       }
       {
         String message = errors.get(1).getMessage();
         assertTrue(message, message.contains("'F.foo'"));
         assertTrue(message, message.contains("'F'"));
       }
@@ skipping 91 matching lines @@
                 "class Test {",
                 "  foo() {",
                 "    new I.foo(0);",
                 "  }",
                 "}"));
     // Check errors.
     {
       List<DartCompilationError> errors = libraryResult.getCompilationErrors();
       assertErrors(
           errors,
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_UNRESOLVED, 2, 3, 13),
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_UNRESOLVED, 8, 9, 5));
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_UNRESOLVED, 2, 3, 13),
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_UNRESOLVED, 8, 9, 5));
       {
         String message = errors.get(0).getMessage();
         assertTrue(message, message.contains("'I.foo'"));
         assertTrue(message, message.contains("'F'"));
       }
     }
     DartUnit unit = libraryResult.getLibraryUnitResult().getUnits().iterator().next();
     // "new I.foo()"
     {
       DartNewExpression newExpression = findNewExpression(unit, "new I.foo(0)");
@@ skipping 24 matching lines @@
                 "  foo() {",
                 "    new I.foo();",
                 "  }",
                 "}"));
     assertErrors(libraryResult.getTypeErrors());
     // Check errors.
     {
       List<DartCompilationError> errors = libraryResult.getCompilationErrors();
       assertErrors(
           errors,
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_NUMBER_OF_REQUIRED_PARAMETERS, 2, 3, 13));
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_NUMBER_OF_REQUIRED_PARAMETERS, 2, 3, 13));
       {
         String message = errors.get(0).getMessage();
         assertTrue(message, message.contains("'F.foo'"));
         assertTrue(message, message.contains("'F'"));
         assertTrue(message, message.contains("0"));
         assertTrue(message, message.contains("1"));
         assertTrue(message, message.contains("'F.foo'"));
       }
     }
     DartUnit unit = libraryResult.getLibraryUnitResult().getUnits().iterator().next();
@@ skipping 35 matching lines @@
                 "    new I.bar(0);",
                 "    new I.baz(0);",
                 "  }",
                 "}"));
     assertErrors(libraryResult.getTypeErrors());
     // Check errors.
     {
       List<DartCompilationError> errors = libraryResult.getCompilationErrors();
       assertErrors(
           errors,
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_NAMED_PARAMETERS, 2, 3, 29),
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_NAMED_PARAMETERS, 3, 3, 29),
-          errEx(ResolverErrorCode.FACTORY_CONSTRUCTOR_NAMED_PARAMETERS, 4, 3, 22));
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_NAMED_PARAMETERS, 2, 3, 29),
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_NAMED_PARAMETERS, 3, 3, 29),
+          errEx(ResolverErrorCode.DEFAULT_CONSTRUCTOR_NAMED_PARAMETERS, 4, 3, 22));
       {
         String message = errors.get(0).getMessage();
         assertTrue(message, message.contains("'I.foo'"));
         assertTrue(message, message.contains("'F'"));
         assertTrue(message, message.contains("[b]"));
         assertTrue(message, message.contains("[b, c]"));
         assertTrue(message, message.contains("'F.foo'"));
       }
       {
         String message = errors.get(1).getMessage();
@@ skipping 26 matching lines @@
       assertEquals(true, constructorNode.toSource().contains("F.bar("));
     }
     // "new I.baz()" - resolved, but we produce error.
     {
       DartNewExpression newExpression = findNewExpression(unit, "new I.baz(0)");
       DartNode constructorNode = newExpression.getSymbol().getNode();
       assertEquals(true, constructorNode.toSource().contains("F.baz("));
     }
   }
 }