Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 8947: Fix the JSC build.... (Closed)

Created:
12 years, 1 month ago by darin (slow to review)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the JSC build. This involved fixing up vcproj files and making some KJS -> JSC changes. I also had to fix some issues related to ScriptCallContext. I had to create a ScriptControllerChromium.cpp for the JSC build to provide an implementation of createScriptInstanceForWidget that knows how to talk to our plugin implementation. This file belongs in bindings/js alongside files like ScriptControllerWin.cpp, so I created webkit/port/bindings/js to house it. R=dglazkov,ojan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -586 lines) Patch
M webkit/build/JavaScriptCore/JavaScriptCore.vcproj View 3 chunks +28 lines, -8 lines 0 comments Download
M webkit/build/JavaScriptCore/JavaScriptCore_pcre.vcproj View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/build/KJSBindings/KJSBindings.vcproj View 14 chunks +96 lines, -32 lines 1 comment Download
M webkit/glue/cpp_bound_class.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/npruntime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webframe_impl.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/pending/ExceptionContext.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/port/bindings/js/ScriptControllerChromium.cpp View 2 chunks +6 lines, -524 lines 0 comments Download
M webkit/port/page/inspector/InspectorController.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
12 years, 1 month ago (2008-10-31 01:34:47 UTC) #1
Peter Kasting
LGTM. Some time we should rename "KJSBindings" and various other vcprojs, vsprops, etc. to "JSCBindings", ...
12 years, 1 month ago (2008-10-31 01:42:34 UTC) #2
dglazkov
12 years, 1 month ago (2008-10-31 02:47:55 UTC) #3
LGTM2

Powered by Google App Engine
This is Rietveld 408576698