Issue 8943001: Fix mac chromedriver tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8943001: Fix mac chromedriver tests (Closed)

Created:
9 years ago by kkania

Modified:
9 years ago

Reviewers:
Huyen

CC:
chromium-reviews, kkania, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Re-enable most mac chromedriver tests after fixing chromedriver shutdown with modal dialogs on mac. Also, don't inline scripts in view_checks.html and do print filter for rerunning failed tests. BUG=103434, 107573 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114650

Patch Set 1 : ... #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -42 lines)			Patch
M	chrome/test/webdriver/test/chromedriver_tests.py	View	14 chunks	+41 lines, -32 lines	0 comments	Download
M	chrome/test/webdriver/test/infobar_browser_action_extension/view_checks.html	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/test/webdriver/test/page_action_extension/view_checks.html	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/test/webdriver/test/py_unittest_util.py	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/test/run_chromedriver_tests.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_automation.cc	View	2 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

No LGTM from valid reviewers yet.

Expand Messages | Collapse Messages